[GitHub] [cordova-android] Chuckytuh commented on issue #1388: onRequestPermissionResult deprecation issue

[GitBox <gi...@apache.org>]

Chuckytuh commented on issue #1388:
URL: https://github.com/apache/cordova-android/issues/1388#issuecomment-1029474414


   `CordovaInterfaceImpl` is directly calling the deprecated method `onRequestPermissionResult` but the deprecation annotation is pushing developers to override the new method that is never executed. 
   
   Also, does it make sense for the `PermissionHelper` to execute both the deprecated and the new methods? That seems like a source of bugs lurking around for plugins as it isn't explicit that both will be executed and mainly because `PermissionHelper` is to provide back compatibility with potentially legacy code.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org