You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 05:18:42 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
MaxGekk opened a new pull request #28723:
URL: https://github.com/apache/spark/pull/28723
### What changes were proposed in this pull request?
Enable `date.sql` and run it via Thrift Server in `ThriftServerQueryTestSuite`.
### Why are the changes needed?
To improve test coverage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the enabled tests via:
```
$ build/sbt -Phive-thriftserver "hive-thriftserver/test-only *ThriftServerQueryTestSuite -- -z date.sql"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638617103
**[Test build #123519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123519/testReport)** for PR 28723 at commit [`81f63e0`](https://github.com/apache/spark/commit/81f63e0387e68837b59926beae7b648b2262a022).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28723:
URL: https://github.com/apache/spark/pull/28723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638614573
@HyukjinKwon I guess this PR fixes the issue mainly:
https://github.com/apache/spark/pull/28582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638634561
Let's cut out RC3 first and then merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608499
**[Test build #123519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123519/testReport)** for PR 28723 at commit [`81f63e0`](https://github.com/apache/spark/commit/81f63e0387e68837b59926beae7b648b2262a022).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-639285714
I discussed with @MaxGekk @cloud-fan. The tests will have to be disabled back at SPARK-30808. Basically, resulting to `0045-03-15` itself is actually controversial.
We strictly _can just merge_ and enable it for Spark 3.0 specifically because SPARK-30808 won't land to `branch-3.0` but let me just don't merge this for simplicity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608339
@HyukjinKwon Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638617236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608705
Looks good if the tests pass. WDYT can you point out which change fixed this if you already know?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638617236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28723:
URL: https://github.com/apache/spark/pull/28723#discussion_r435695747
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -68,8 +68,6 @@ class ThriftServerQueryTestSuite extends SQLQueryTestSuite with SharedThriftServ
// Missing UDF
"postgreSQL/boolean.sql",
"postgreSQL/case.sql",
- // SPARK-28624
- "date.sql",
Review comment:
thriftserver doesn't support negative year, I think we still need to ignore this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28723:
URL: https://github.com/apache/spark/pull/28723#issuecomment-638608499
**[Test build #123519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123519/testReport)** for PR 28723 at commit [`81f63e0`](https://github.com/apache/spark/commit/81f63e0387e68837b59926beae7b648b2262a022).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org