You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/06 05:24:38 UTC
[PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
aglinxinyuan opened a new pull request, #6209:
URL: https://github.com/apache/texera/pull/6209
### What changes were proposed in this PR?
`computing-unit-managing-service` crashes at startup on `main` (since #6185, the Arrow 19 upgrade) with:
```
Exception in thread "main" com.fasterxml.jackson.databind.JsonMappingException:
Scala module 2.18.8 requires Jackson Databind version >= 2.18.0 and < 2.19.0
- Found jackson-databind version 2.21.0
at com.fasterxml.jackson.module.scala.JacksonModule.setupModule
at org.apache.texera.service.ComputingUnitManagingService.initialize
```
**Root cause.** #6185 counters Arrow 19 evicting `jackson-databind` up to `2.21.0` (past the range `jackson-module-scala` allows) by pinning the Jackson core family — in `workflow-core`/`workflow-operator`, and by pinning `jackson-databind` directly in `file-service` and `workflow-compiling-service`. `ComputingUnitManagingService` was the one Arrow-bundling service left overriding **only** `jackson-module-scala`, so nothing held `jackson-databind` down. Its dist bundled `jackson-databind-2.21.0.jar` next to `jackson-module-scala_2.13-2.18.8.jar` and aborted at init.
**Before → after** (resolved `Runtime/managedClasspath` of `ComputingUnitManagingService`):
| artifact | before | after |
| --- | --- | --- |
| jackson-annotations | 2.21 | 2.21 |
| jackson-core | 2.21.0 | 2.21.0 |
| **jackson-databind** | **2.21.0** ❌ | **2.18.8** ✅ |
The fix mirrors `file-service` / `workflow-compiling-service` exactly: add `"com.fasterxml.jackson.core" % "jackson-databind" % jacksonVersion` to the module's `dependencyOverrides`, and re-sync the one drifted line in `computing-unit-managing-service/LICENSE-binary` (`2.21.0` → `2.18.8`). `NOTICE-binary` is version-less by design (the generator strips versions so routine bumps don't churn it) and the jar *set* is unchanged, so it needs no edit.
### Any related issues, documentation, discussions?
Fixes #6206. Follow-up to #6185.
### How was this PR tested?
Reproduced the CI binary-license check locally against the module's resolved runtime classpath (per the repo's `check_binary_deps.py` recipe):
- `sbt "print ComputingUnitManagingService/Runtime/managedClasspath"` now resolves `jackson-databind-2.18.8.jar` (was `2.21.0`) — the only delta; no other dep drifted.
- `check_binary_deps.py jar <staged-lib> --license-binary computing-unit-managing-service/LICENSE-binary` → `OK: 339 JVM jars match LICENSE-binary.`
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6209:
URL: https://github.com/apache/texera/pull/6209#issuecomment-4889376037
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Yicong-Huang`
You can notify them by mentioning `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6209:
URL: https://github.com/apache/texera/pull/6209#issuecomment-4889386837
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.93%. Comparing base ([`4473a25`](https://app.codecov.io/gh/apache/texera/commit/4473a255d87e6f24b17ccbdaf812d8e587bfb1f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`43685f7`](https://app.codecov.io/gh/apache/texera/commit/43685f7a2819bbe2eea48eb00113b4c54c9f630f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6209 +/- ##
=========================================
Coverage 59.92% 59.93%
- Complexity 3306 3309 +3
=========================================
Files 1131 1131
Lines 43805 43805
Branches 4745 4745
=========================================
+ Hits 26252 26254 +2
+ Misses 16128 16127 -1
+ Partials 1425 1424 -1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.13% <ø> (+0.01%)` | :arrow_up: | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.81% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.48% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.18% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [27d0eab](https://app.codecov.io/gh/apache/texera/commit/27d0eabc0f9ad0b2905a0fccb493ec47162929bc?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6209?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #6209:
URL: https://github.com/apache/texera/pull/6209#discussion_r3526628901
##########
common/workflow-core/build.sbt:
##########
@@ -157,6 +157,9 @@ dependencyOverrides ++= Seq(
// Iceberg-related Dependencies
/////////////////////////////////////////////////////////////////////////////
val excludeJersey = ExclusionRule(organization = "com.sun.jersey")
+// Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
+// providers break Jersey 2 auto-discovery at startup, so exclude it as well.
+val excludeJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
Review Comment:
Good catch — those extra changes were an artifact of the branch being cut from a local main that still carried a duplicate of #6205 (the jersey-json exclusion), so GitHub picked a merge-base before it and folded that diff in. I've rebased onto current apache/main and dropped the duplicate — the PR is now just the two intended files (the `build.sbt` jackson-databind pin and the one-line `computing-unit-managing-service/LICENSE-binary` resync).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6209:
URL: https://github.com/apache/texera/pull/6209#issuecomment-4889401774
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 3 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `5d37f3b` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28769790526)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 399 | 0.243 | 24,217/32,767/32,767 us | 🔴 +16.1% / 🔴 +115.4% |
| ⚪ | bs=100 sw=10 sl=64 | 817 | 0.498 | 119,921/141,633/141,633 us | ⚪ within ±5% / 🔴 +31.2% |
| ⚪ | bs=1000 sw=10 sl=64 | 924 | 0.564 | 1,086,430/1,126,663/1,126,663 us | ⚪ within ±5% / 🔴 +10.1% |
<details><summary>Baseline details</summary>
Latest main `5d37f3b` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 399 tuples/sec | 440 tuples/sec | 777.63 tuples/sec | -9.3% | -48.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.243 MB/s | 0.268 MB/s | 0.475 MB/s | -9.3% | -48.8% |
| bs=10 sw=10 sl=64 | p50 | 24,217 us | 20,860 us | 12,603 us | +16.1% | +92.2% |
| bs=10 sw=10 sl=64 | p95 | 32,767 us | 37,385 us | 15,215 us | -12.4% | +115.4% |
| bs=10 sw=10 sl=64 | p99 | 32,767 us | 37,385 us | 18,617 us | -12.4% | +76.0% |
| bs=100 sw=10 sl=64 | throughput | 817 tuples/sec | 821 tuples/sec | 987.11 tuples/sec | -0.5% | -17.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.498 MB/s | 0.501 MB/s | 0.602 MB/s | -0.6% | -17.3% |
| bs=100 sw=10 sl=64 | p50 | 119,921 us | 118,625 us | 101,428 us | +1.1% | +18.2% |
| bs=100 sw=10 sl=64 | p95 | 141,633 us | 147,413 us | 107,959 us | -3.9% | +31.2% |
| bs=100 sw=10 sl=64 | p99 | 141,633 us | 147,413 us | 114,777 us | -3.9% | +23.4% |
| bs=1000 sw=10 sl=64 | throughput | 924 tuples/sec | 915 tuples/sec | 1,021 tuples/sec | +1.0% | -9.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.564 MB/s | 0.558 MB/s | 0.623 MB/s | +1.1% | -9.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,086,430 us | 1,099,275 us | 986,363 us | -1.2% | +10.1% |
| bs=1000 sw=10 sl=64 | p95 | 1,126,663 us | 1,127,333 us | 1,026,594 us | -0.1% | +9.7% |
| bs=1000 sw=10 sl=64 | p99 | 1,126,663 us | 1,127,333 us | 1,054,559 us | -0.1% | +6.8% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,501.61,200,128000,399,0.243,24216.79,32766.90,32766.90
1,100,10,64,20,2449.09,2000,1280000,817,0.498,119920.53,141632.88,141632.88
2,1000,10,64,20,21643.20,20000,12800000,924,0.564,1086430.09,1126662.93,1126662.93
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6209:
URL: https://github.com/apache/texera/pull/6209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6209:
URL: https://github.com/apache/texera/pull/6209#discussion_r3526597878
##########
common/workflow-core/build.sbt:
##########
@@ -157,6 +157,9 @@ dependencyOverrides ++= Seq(
// Iceberg-related Dependencies
/////////////////////////////////////////////////////////////////////////////
val excludeJersey = ExclusionRule(organization = "com.sun.jersey")
+// Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
+// providers break Jersey 2 auto-discovery at startup, so exclude it as well.
+val excludeJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
Review Comment:
The PR description says this change “mirrors file-service / workflow-compiling-service exactly” and that only one line drifted in `computing-unit-managing-service/LICENSE-binary`, but this PR also updates `common/workflow-core/build.sbt` (new Hadoop jersey-json exclusion), `amber/build.sbt`, and multiple other `LICENSE-binary*` files. Please update the PR title/description (or split into a separate PR) so reviewers can clearly track the additional dependency/licensing changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #6209:
URL: https://github.com/apache/texera/pull/6209#discussion_r3526629633
##########
common/workflow-core/build.sbt:
##########
@@ -157,6 +157,9 @@ dependencyOverrides ++= Seq(
// Iceberg-related Dependencies
/////////////////////////////////////////////////////////////////////////////
val excludeJersey = ExclusionRule(organization = "com.sun.jersey")
+// Hadoop 3.3.2+ ships jersey-json via the com.github.pjfanning fork; its Jersey 1.x
+// providers break Jersey 2 auto-discovery at startup, so exclude it as well.
+val excludeJerseyJsonFork = ExclusionRule(organization = "com.github.pjfanning", name = "jersey-json")
Review Comment:
seems outdated info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps): pin jackson-databind to 2.18.8 in computing-unit-managing-service [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #6209:
URL: https://github.com/apache/texera/pull/6209#issuecomment-4889457497
Tested running the service locally, and it works.
<img width="2220" height="757" alt="image" src="https://github.com/user-attachments/assets/49944413-1335-4442-82b2-1aa883d7e867" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org