You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Joel Muzzerall (JIRA)" <ji...@apache.org> on 2008/12/20 00:34:44 UTC
[jira] Updated: (BUILDR-230) release task fails if there's a space
in the path to the Buildfile
[ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Muzzerall updated BUILDR-230:
----------------------------------
Attachment: fix_for_buildr-230.patch
Here's a fix. Not sure what the best way to make a spec for this one is. The line that triggers the symptom is in lib/buildr/core/build.rb in Release::buildr which is protected. It's only called from Release::buildr, the specs for which stub out the make function.
> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
> Key: BUILDR-230
> URL: https://issues.apache.org/jira/browse/BUILDR-230
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.3.3
> Reporter: Alex Boisvert
> Fix For: 1.3.4
>
> Attachments: fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN - from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN - from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN - from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN -
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.