You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2017/06/20 16:21:00 UTC
[jira] [Commented] (QPID-7459)
ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10
profiles
[ https://issues.apache.org/jira/browse/QPID-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056031#comment-16056031 ]
Keith Wall commented on QPID-7459:
----------------------------------
commit bdb6338f3b5afb7648506dbe35a39cf5f5564374
Author: Keith Wall <kw...@apache.org>
Date: Thu Jun 1 17:40:43 2017 +0100
NO-JIRA: [Java System Tests] Fix racey ProducerFlowControlTest#testCapacityExceedsBlock
> ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles
> -------------------------------------------------------------------------------
>
> Key: QPID-7459
> URL: https://issues.apache.org/jira/browse/QPID-7459
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Keith Wall
> Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: TEST-org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout.txt
>
>
> ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles.
> The test is racey. The test relies on message n-1 causing flow control to be imposed before the test can try to send message n. If flow control is not imposed before the client tries to send message n, the test will fail. In the failing case the client has not processed the incoming MessageStop before it sends message n. The test tries tries to prevent this by sync'ing twice. This approach is ineffective for 0-10 as the send sync to optimised out and does not caused an ExecutionSync.
> The test issue does not affect the usefulness of the feature itself.
> https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-Java-Java-Test-JDK1.8/1801/artifact/trunk/systests/target/surefire-reports/java-mms.0-10/
> {noformat}
> junit.framework.AssertionFailedError: No timeout exception on sending
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.assertTrue(Assert.java:22)
> at junit.framework.Assert.assertNotNull(Assert.java:256)
> at junit.framework.TestCase.assertNotNull(TestCase.java:426)
> at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:284)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org