[GitHub] markusthoemmes commented on a change in pull request #3394: fix deploy.yml

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3394: fix deploy.yml
URL: https://github.com/apache/incubator-openwhisk/pull/3394#discussion_r172536083
 
 

 ##########
 File path: ansible/roles/cli/tasks/deploy.yml
 ##########
 @@ -48,10 +50,7 @@
     -C {{ openwhisk_build_dir }}/{{ openwhisk_cli.archive_name }}/
 
 - name: "Copy expanded archive to final configuration directory"
-  copy:
-    #  WARNING:  The trailing slash is significant, signalling to copy contents
-    src: "{{ openwhisk_build_dir }}/{{ openwhisk_cli.archive_name }}/"
-    dest: "{{ openwhisk_cli.nginxdir.name }}"
+  shell: cp -r {{ openwhisk_build_dir }}/{{ openwhisk_cli.archive_name }}/ {{ openwhisk_cli.nginxdir.name }}
 
 Review comment:
   This will not work. If this playbook is run on a remote machine. `copy` does work transparently from local to remote, a shell command won't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services