[GitHub] [spark] cloud-fan commented on a diff in pull request #36576: [SPARK-32268][SQL][TESTS][FOLLOW-UP] Use function registry in the SparkSession

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #36576:
URL: https://github.com/apache/spark/pull/36576#discussion_r874598262


##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -147,6 +147,9 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
   test("SPARK-14415: All functions should have own descriptions") {
     for (f <- spark.sessionState.functionRegistry.listFunction()) {
       if (!Seq("cube", "grouping", "grouping_id", "rollup").contains(f.unquotedString)) {
+        if (f.unquotedString == "bloom_filter_agg") {

Review Comment:
   do we need this? it looks weird to handle `bloom_filter_agg` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org