You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2024/02/05 12:10:40 UTC

Re: [PR] fix lost trace when multi middleware handlerFunc [skywalking-go]

mrproliu commented on code in PR #167:
URL: https://github.com/apache/skywalking-go/pull/167#discussion_r1478104412


##########
plugins/gin/intercepter.go:
##########
@@ -59,3 +62,10 @@ func (h *ContextInterceptor) AfterInvoke(invocation operator.Invocation, result
 	span.End()
 	return nil
 }
+
+func isFirstHandle(c interface{}) bool {
+	if context, ok := c.(*nativeContext); ok {
+		return context.index < 0

Review Comment:
   Following your [diagram in the comment](https://github.com/apache/skywalking/issues/11852#issuecomment-1918727190), I think It should equal zero? Please correct me if am wrong. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org