You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/03/07 01:31:46 UTC
[Impala-ASF-CR] [stress] factor out MemBroker into its own file.
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12687
Change subject: [stress] factor out MemBroker into its own file.
......................................................................
[stress] factor out MemBroker into its own file.
This is a cut-and-paste with the appropriate manual updates to
import statements.
The only motivation is to make concurrent_select.py less intimidating.
Testing:
Ran a short local stress test.
Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
---
M tests/stress/concurrent_select.py
A tests/stress/mem_broker.py
2 files changed, 124 insertions(+), 96 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/12687/1
--
To view, visit http://gerrit.cloudera.org:8080/12687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [stress] factor out MemBroker into its own file.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12687 )
Change subject: [stress] factor out MemBroker into its own file.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3907/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:55:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] factor out MemBroker into its own file.
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12687 )
Change subject: [stress] factor out MemBroker into its own file.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Mar 2019 22:08:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] factor out MemBroker into its own file.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12687 )
Change subject: [stress] factor out MemBroker into its own file.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:55:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] factor out MemBroker into its own file.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12687 )
Change subject: [stress] factor out MemBroker into its own file.
......................................................................
[stress] factor out MemBroker into its own file.
This is a cut-and-paste with the appropriate manual updates to
import statements.
The only motivation is to make concurrent_select.py less intimidating.
Testing:
Ran a short local stress test.
Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Reviewed-on: http://gerrit.cloudera.org:8080/12687
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/stress/concurrent_select.py
A tests/stress/mem_broker.py
2 files changed, 124 insertions(+), 96 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] [stress] factor out MemBroker into its own file.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12687 )
Change subject: [stress] factor out MemBroker into its own file.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475d2e166bbf940e89135ea04be7b3003c37141b
Gerrit-Change-Number: 12687
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 22:11:21 +0000
Gerrit-HasComments: No