You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "rpuch (via GitHub)" <gi...@apache.org> on 2025/08/04 13:11:14 UTC

[PR] IGNITE-26051 Ignore destroyed tables in write intent switch command [ignite-3]

rpuch opened a new pull request, #6362:
URL: https://github.com/apache/ignite-3/pull/6362

   https://issues.apache.org/jira/browse/IGNITE-26051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-26051 Ignore destroyed tables in write intent switch command [ignite-3]

Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #6362:
URL: https://github.com/apache/ignite-3/pull/6362#discussion_r2251666064


##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/handlers/WriteIntentSwitchCommandHandler.java:
##########
@@ -55,7 +59,17 @@ protected CommandResult handleInternally(
 
         boolean applied = false;
         for (int tableId : ((WriteIntentSwitchCommandV2) switchCommand).tableIds()) {
-            CommandResult singleResult = raftTableProcessor(tableId)
+            RaftTableProcessor tableProcessor = raftTableProcessor(tableId);
+
+            if (tableProcessor == null) {
+                // This can only happen if the table in question has already been dropped and destroyed. In such case, we simply
+                // don't need to do anything as the partition storage is already destroyed.
+                LOG.debug("Table processor for table ID {} not found. Command execution for the table will be ignored: {}",

Review Comment:
   Maybe we should do logging explicitly with a debug enabled check so that `switchCommand.toStringForLightLogging()` is not executed in vain.



##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/handlers/WriteIntentSwitchCommandHandler.java:
##########
@@ -65,10 +79,6 @@ protected CommandResult handleInternally(
     }
 
     private RaftTableProcessor raftTableProcessor(int tableId) {

Review Comment:
   ```suggestion
       private @Nullable RaftTableProcessor raftTableProcessor(int tableId) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-26051 Ignore destroyed tables in write intent switch command [ignite-3]

Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch merged PR #6362:
URL: https://github.com/apache/ignite-3/pull/6362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org