You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2015/06/13 20:07:45 UTC
[GitHub] metamodel pull request: Added HdfsResource integration test
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/26
Added HdfsResource integration test
Trying to make the story more complete wrt. the HdfsResource testability. I made it use our normal integration test approach of having properties in ${user.home}/metamodel-integrationtest-configuration.properties that drive the setup of the test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit bbc460f75e353674fd4e7f0bbd2c4b927d67092a
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-06-11T21:17:09Z
Fixed current build issues with missing license headers & banned deps
commit 4496872efafd823cfc3331c1771f7fcdef8f66b7
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-06-13T18:01:22Z
Added a proper integration test for the HdfsResource
commit 839926bc66eb0988cfb0764c511dd088d886517a
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-06-13T18:01:46Z
Added license header
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added HdfsResource integration test
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/26#issuecomment-111752962
Just also pushed a change HdfsResource so that it no longer implements Closeable. This was never a good design I think and would make handling this Resource implementation much different from other implementations. I did some simple benchmarks of speed (using the integration test) and in 10 runs with both codebases it showed that the impact didn't matter (on the small file at least - but with larger files any difference should actually even out theoretically since the only potential penalty is around "chatty" interactions).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added HdfsResource integration test
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---