You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/23 18:29:19 UTC
[GitHub] [superset] mistercrunch opened a new issue #13303: [home page] make the tab/pills sticky
mistercrunch opened a new issue #13303:
URL: https://github.com/apache/superset/issues/13303
<img width="520" alt="Screen Shot 2021-02-23 at 10 26 10 AM" src="https://user-images.githubusercontent.com/487433/108889803-a1e1cd80-75c1-11eb-903c-74ef4b0af593.png">
I take the time to set my favorite dashboards and charts, but the home page won't remember that I prefer "Favorites" over "Mine". Let's make that sticky. Let's also create a nice simple abstraction for things to be sticky. Maybe that becomes a `sticky` React prop for our Tab/Pills component in our design system (?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784418946
I would be nice to create a framework where this is saved in the metadata db instead of local storage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784425476
Let's just work with a good abstraction that should allow us to switch over to a different storage mechanism later on. As the UI gets more complex and we create more of these sticky options, it would be a shame for all of that to be lost once someone upgrades to a new computer which is fairly common in corporate settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784419581
my first reaction is local storage, that's how we set in Explore, but after thinking through, it might make more sense to save it in metadata db. @nytai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784418255
local storage @nytai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784417343
As in save the preference to local storage or in metadata db?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784614946
+1 on good abstraction. Another benefit of saving things like this to db is cross-platform/browser consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on issue #13303: [home page] make the tab/pills sticky
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on issue #13303:
URL: https://github.com/apache/superset/issues/13303#issuecomment-784418255
local storage @nytai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org