You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/27 02:35:19 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4236: bcm43xxx: fixed issues with unaligned buffers for DMA transfers.

xiaoxiang781216 commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677073264



##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.h
##########
@@ -42,11 +42,40 @@
  ****************************************************************************/
 
 #define HEADER_SIZE        0x12 /* Default sdpcm + bdc header size */
+#define FIRST_WORD_SIZE    4
 
 /* TODO move to Kconfig */
 
 #define BCMF_PKT_POOL_SIZE 4    /* Frame pool size */
 
+#if defined(CONFIG_STM32_STM32F10XX)

Review comment:
       it isn't good to reference SOC specific config in a common driver.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org