You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Irmo Manie <no...@github.com> on 2015/09/01 11:29:58 UTC

[jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

…and map it in the underlying adapter.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/852

-- Commit Summary --

  * JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` and map it in the underlying adapter.

-- File Changes --

    M apis/cloudstack/src/main/java/org/jclouds/cloudstack/compute/options/CloudStackTemplateOptions.java (32)
    M apis/cloudstack/src/main/java/org/jclouds/cloudstack/compute/strategy/CloudStackComputeServiceAdapter.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/852.patch
https://github.com/jclouds/jclouds/pull/852.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852

Re: [jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

Posted by Ignasi Barrera <no...@github.com>.

Closed #852.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852#event-402299776

Re: [jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

Posted by Ignasi Barrera <no...@github.com>.

It is ok. Thanks! I'll squash the commits when merging.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852#issuecomment-137369180

Re: [jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

Posted by Ignasi Barrera <no...@github.com>.

Thanks @momania! lgtm. Just a minor comment: could you double-check the formatting and [use a 3 space indentation](https://cwiki.apache.org/confluence/display/JCLOUDS/Coding+Standards)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852#issuecomment-137268774

Re: [jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

Posted by Irmo Manie <no...@github.com>.

Sure, I'll update the pull request later today to fix that.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852#issuecomment-137357311

Re: [jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

Posted by Irmo Manie <no...@github.com>.

@nacx Is it ok like this, or do you want me to squash it together as 1 commit?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852#issuecomment-137359752

Re: [jclouds] JCLOUDS-995 - Add `userData` property to `CloudStackTemplateOptions` … (#852)

Posted by Ignasi Barrera <no...@github.com>.

Squashed and pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/89f81840) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1ef5c701). Thanks @momania!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/852#issuecomment-138133835