[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2887: NO-JIRA make OpenWire test more robust

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2887: NO-JIRA make OpenWire test more robust
URL: https://github.com/apache/activemq-artemis/pull/2887#discussion_r344192471
 
 

 ##########
 File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/TemporaryQueueClusterTest.java
 ##########
 @@ -64,20 +66,23 @@ public void testClusteredQueue() throws Exception {
          Session session2 = conn2.createSession(false, Session.AUTO_ACKNOWLEDGE);
          Queue targetQueue2 = session2.createQueue(QUEUE_NAME);
 
-
          this.waitForBindings(servers[0], QUEUE_NAME, true, 1, 0, 2000);
          this.waitForBindings(servers[1], QUEUE_NAME, true, 1, 0, 2000);
          this.waitForBindings(servers[1], QUEUE_NAME, false, 1, 0, 2000);
          this.waitForBindings(servers[0], QUEUE_NAME, false, 1, 0, 2000);
 
-
          MessageProducer prod1 = session1.createProducer(targetQueue1);
          MessageConsumer cons2 = session2.createConsumer(targetQueue2);
 
+         this.waitForBindings(servers[0], QUEUE_NAME, false, 1, 1, 2000);
 
 Review comment:
   This test is about clustering. a lot of tests will make sure the other servers will have their remote bindings before validating a cluster scenario.
   
   This should work fine on a local send. But since the test is validating a cluster scenario, this must be done to guarantee the cluster formation.
   
   I think this is fine. There are a lot of other clustering tests that will wait for the expected binding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services