[GitHub] [dolphinscheduler] qingwli commented on a diff in pull request #14406: [Feature][Data Quality] Data Quality Support Choose Database

["qingwli (via GitHub)" <gi...@apache.org>]

qingwli commented on code in PR #14406:
URL: https://github.com/apache/dolphinscheduler/pull/14406#discussion_r1246002300


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -645,6 +643,55 @@ public Map<String, Object> getTableColumns(Integer datasourceId, String tableNam
         return result;
     }
 
+    @Override
+    public Map<String, Object> getDatabases(Integer datasourceId) {

Review Comment:
   Yes, we can. But looks like not a simple job, because you can see we use map in all data source services. We can update it in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org