You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/08/09 14:38:49 UTC
[jira] [Commented] (HDFS-3020) Auto-logSync based on edit log
buffer size broken
[ https://issues.apache.org/jira/browse/HDFS-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734725#comment-13734725 ]
Hudson commented on HDFS-3020:
------------------------------
ABORTED: Integrated in Hadoop-Hdfs-0.23-Build #694 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/694/])
HDFS-3020. Fix editlog to automatically sync when buffer is full. Contributed by Todd Lipcon. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511968)
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditsDoubleBuffer.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java
> Auto-logSync based on edit log buffer size broken
> -------------------------------------------------
>
> Key: HDFS-3020
> URL: https://issues.apache.org/jira/browse/HDFS-3020
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0-alpha, 0.23.10
>
> Attachments: hdfs-3020.txt, hdfs-3020.txt, hdfs-3020.txt
>
>
> HDFS-1112 added a feature whereby the edit log automatically calls logSync() if the buffered data crosses a threshold. However, the code checks {{bufReady.size()}} rather than {{bufCurrent.size()}} -- which is incorrect since the writes themselves go into {{bufCurrent}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira