You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/19 17:54:16 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #7212:
[AIRFLOW-XXXX] Update committers list
nuclearpinguin opened a new pull request #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212
I updated the list of committers according to:
http://people.apache.org/phonebook.html?unix=airflow
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7212:
[AIRFLOW-XXXX] Update committers list
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212#discussion_r368313631
##########
File path: docs/project.rst
##########
@@ -36,34 +36,36 @@ in January 2019.
Committers
----------
-- @mistercrunch (Maxime "Max" Beauchemin)
-- @r39132 (Siddharth "Sid" Anand)
-- @criccomini (Chris Riccomini)
-- @bolkedebruin (Bolke de Bruin)
+- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @alexvanboxel (Alex Van Boxel)
- @artwr (Arthur Wiedmer)
-- @jlowin (Jeremiah Lowin)
+- @ash (Ash Berlin-Taylor)
+- @basph (Bas Harenslak)
+- @bolkedebruin (Bolke de Bruin)
+- @criccomini (Chris Riccomini)
- @aoen (Dan Davydov)
-- @msumit (Sumit Maheshwari)
-- @alexvanboxel (Alex Van Boxel)
-- @saguziel (Alex Guziel)
-- @joygao (Joy Gao)
+- @dimberman (Daniel Imberman)
+- @feluelle (Felix Uellendall)
- @fokko (Fokko Driesprong)
-- @ash (Ash Berlin-Taylor)
-- @kaxilnaik (Kaxil Naik)
-- @feng-tao (Tao Feng)
- @hiteshs (Hitesh Shah)
- @jghoman (Jakob Homan)
-- @XD-DENG (Xiaodong Deng)
-- @dimberman (Daniel Imberman)
-- @potiuk (Jarek Potiuk)
-- @basph (Bas Harenslak)
+- @jlowin (Jeremiah Lowin)
- @jmcarp (Joshua Carp)
-- @KevinYang21 (Kevin Yang)
+- @joygao (Joy Gao)
- @mik-laj (Kamil Breguła)
-- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @kaxilnaik (Kaxil Naik)
+- @KevinYang21 (Kevin Yang)
+- @mistercrunch (Maxime Beauchemin)
- @milton0825 (Chao-Han Tsai)
-- @feluelle (Felix Uellendall)
-
+- @msumit (Sumit Maheshwari)
+- @pltardif (Patrick Leo Tardif)
+- @potiuk (Jarek Potiuk)
+- @saguziel (Alex Guziel)
Review comment:
> Ok, I will sort it A-Z. I wanted to keep the order consistent with this provided by Apache (I haven't figured the rule :D )
But the apache list lists apache handles and the project.rst lists github handles?!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7212:
[AIRFLOW-XXXX] Update committers list
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212#discussion_r368311906
##########
File path: docs/project.rst
##########
@@ -36,34 +36,36 @@ in January 2019.
Committers
----------
-- @mistercrunch (Maxime "Max" Beauchemin)
-- @r39132 (Siddharth "Sid" Anand)
-- @criccomini (Chris Riccomini)
-- @bolkedebruin (Bolke de Bruin)
+- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @alexvanboxel (Alex Van Boxel)
- @artwr (Arthur Wiedmer)
-- @jlowin (Jeremiah Lowin)
+- @ash (Ash Berlin-Taylor)
+- @basph (Bas Harenslak)
+- @bolkedebruin (Bolke de Bruin)
+- @criccomini (Chris Riccomini)
- @aoen (Dan Davydov)
-- @msumit (Sumit Maheshwari)
-- @alexvanboxel (Alex Van Boxel)
-- @saguziel (Alex Guziel)
-- @joygao (Joy Gao)
+- @dimberman (Daniel Imberman)
+- @feluelle (Felix Uellendall)
- @fokko (Fokko Driesprong)
-- @ash (Ash Berlin-Taylor)
-- @kaxilnaik (Kaxil Naik)
-- @feng-tao (Tao Feng)
- @hiteshs (Hitesh Shah)
- @jghoman (Jakob Homan)
-- @XD-DENG (Xiaodong Deng)
-- @dimberman (Daniel Imberman)
-- @potiuk (Jarek Potiuk)
-- @basph (Bas Harenslak)
+- @jlowin (Jeremiah Lowin)
- @jmcarp (Joshua Carp)
-- @KevinYang21 (Kevin Yang)
+- @joygao (Joy Gao)
- @mik-laj (Kamil Breguła)
-- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @kaxilnaik (Kaxil Naik)
+- @KevinYang21 (Kevin Yang)
+- @mistercrunch (Maxime Beauchemin)
- @milton0825 (Chao-Han Tsai)
-- @feluelle (Felix Uellendall)
-
+- @msumit (Sumit Maheshwari)
+- @pltardif (Patrick Leo Tardif)
+- @potiuk (Jarek Potiuk)
+- @saguziel (Alex Guziel)
Review comment:
Aah I thought you wanted to sort it 😄 Apache sorts it based on (Date, Names) the person becomes committer. When Airflow graduated into a Top Level Project, the PPMC became PMC at the same dates. Hence, they are sorted according to Names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7212: [AIRFLOW-XXXX] Update committers list
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212#discussion_r368311578
##########
File path: docs/project.rst
##########
@@ -36,34 +36,36 @@ in January 2019.
Committers
----------
-- @mistercrunch (Maxime "Max" Beauchemin)
-- @r39132 (Siddharth "Sid" Anand)
-- @criccomini (Chris Riccomini)
-- @bolkedebruin (Bolke de Bruin)
+- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @alexvanboxel (Alex Van Boxel)
- @artwr (Arthur Wiedmer)
-- @jlowin (Jeremiah Lowin)
+- @ash (Ash Berlin-Taylor)
+- @basph (Bas Harenslak)
+- @bolkedebruin (Bolke de Bruin)
+- @criccomini (Chris Riccomini)
- @aoen (Dan Davydov)
-- @msumit (Sumit Maheshwari)
-- @alexvanboxel (Alex Van Boxel)
-- @saguziel (Alex Guziel)
-- @joygao (Joy Gao)
+- @dimberman (Daniel Imberman)
+- @feluelle (Felix Uellendall)
- @fokko (Fokko Driesprong)
-- @ash (Ash Berlin-Taylor)
-- @kaxilnaik (Kaxil Naik)
-- @feng-tao (Tao Feng)
- @hiteshs (Hitesh Shah)
- @jghoman (Jakob Homan)
-- @XD-DENG (Xiaodong Deng)
-- @dimberman (Daniel Imberman)
-- @potiuk (Jarek Potiuk)
-- @basph (Bas Harenslak)
+- @jlowin (Jeremiah Lowin)
- @jmcarp (Joshua Carp)
-- @KevinYang21 (Kevin Yang)
+- @joygao (Joy Gao)
- @mik-laj (Kamil Breguła)
-- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @kaxilnaik (Kaxil Naik)
+- @KevinYang21 (Kevin Yang)
+- @mistercrunch (Maxime Beauchemin)
- @milton0825 (Chao-Han Tsai)
-- @feluelle (Felix Uellendall)
-
+- @msumit (Sumit Maheshwari)
+- @pltardif (Patrick Leo Tardif)
+- @potiuk (Jarek Potiuk)
+- @saguziel (Alex Guziel)
Review comment:
Ok, I will sort it A-Z. I wanted to keep the order consistent with this provided by Apache (I haven't figured the rule :D )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] r39132 commented on issue #7212: [AIRFLOW-XXXX] Update
committers list
Posted by GitBox <gi...@apache.org>.
r39132 commented on issue #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212#issuecomment-576040571
> > Actually, maybe it might make more sense to keep it by Join Date so that people like Max (original creator of Airflow) remains at the top but I don't have a strong opinion if we sort it by name
>
> Agree with @kaxil I think it is nice to sort it by join date.
Yes. It's good when certain conventions help us plot the growth of the project. Similar to the apache committer lists on various Apache pages, the intent was to add folks to this list in committer order, which is the order by which they were added as committers to the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7212:
[AIRFLOW-XXXX] Update committers list
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212#discussion_r368311059
##########
File path: docs/project.rst
##########
@@ -36,34 +36,36 @@ in January 2019.
Committers
----------
-- @mistercrunch (Maxime "Max" Beauchemin)
-- @r39132 (Siddharth "Sid" Anand)
-- @criccomini (Chris Riccomini)
-- @bolkedebruin (Bolke de Bruin)
+- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @alexvanboxel (Alex Van Boxel)
- @artwr (Arthur Wiedmer)
-- @jlowin (Jeremiah Lowin)
+- @ash (Ash Berlin-Taylor)
+- @basph (Bas Harenslak)
+- @bolkedebruin (Bolke de Bruin)
+- @criccomini (Chris Riccomini)
- @aoen (Dan Davydov)
-- @msumit (Sumit Maheshwari)
-- @alexvanboxel (Alex Van Boxel)
-- @saguziel (Alex Guziel)
-- @joygao (Joy Gao)
+- @dimberman (Daniel Imberman)
+- @feluelle (Felix Uellendall)
- @fokko (Fokko Driesprong)
-- @ash (Ash Berlin-Taylor)
-- @kaxilnaik (Kaxil Naik)
-- @feng-tao (Tao Feng)
- @hiteshs (Hitesh Shah)
- @jghoman (Jakob Homan)
-- @XD-DENG (Xiaodong Deng)
-- @dimberman (Daniel Imberman)
-- @potiuk (Jarek Potiuk)
-- @basph (Bas Harenslak)
+- @jlowin (Jeremiah Lowin)
- @jmcarp (Joshua Carp)
-- @KevinYang21 (Kevin Yang)
+- @joygao (Joy Gao)
- @mik-laj (Kamil Breguła)
-- @aijamalnk (Aizhamal Nurmamat kyzy)
+- @kaxilnaik (Kaxil Naik)
+- @KevinYang21 (Kevin Yang)
+- @mistercrunch (Maxime Beauchemin)
- @milton0825 (Chao-Han Tsai)
-- @feluelle (Felix Uellendall)
-
+- @msumit (Sumit Maheshwari)
+- @pltardif (Patrick Leo Tardif)
+- @potiuk (Jarek Potiuk)
+- @saguziel (Alex Guziel)
Review comment:
This should be after "@r39132 Siddharth Anand" for alphabetical order :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7212: [AIRFLOW-XXXX] Update
committers list
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7212: [AIRFLOW-XXXX] Update
committers list
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7212: [AIRFLOW-XXXX] Update committers list
URL: https://github.com/apache/airflow/pull/7212#issuecomment-576034489
>
>
> Actually, maybe it might make more sense to keep it by Join Date so that people like Max (original creator of Airflow) remains at the top but I don't have a strong opinion if we sort it by name
Agree with @kaxil I think it is nice to sort it by join date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services