You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/24 15:04:08 UTC
[GitHub] [dolphinscheduler] MichaelDeSteven opened a new issue, #11130: [Improvement] Refactor dolphinscheduler-alert module
MichaelDeSteven opened a new issue, #11130:
URL: https://github.com/apache/dolphinscheduler/issues/11130
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
### Refactor reason
* Make it clean
* Make it elegant and readability
* Make it easy maintain
### Current situation
1. In dolphinscheduler-alert has many bean class which like below pic.
the refactor purpose is make it clean
2. In some method logic code so long that is difficult to read and maintain
### Next Step
I will improve above problems.
* use lombok to short bean class file length
* applicate `builder design pattern` to create a new object
* make method as small as possible which follows `Single Responsibility Principle`
* add more unit test
* find and fix more unreasonable issue about alert module
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11130: [Improvement] Refactor dolphinscheduler-alert module
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11130:
URL: https://github.com/apache/dolphinscheduler/issues/11130#issuecomment-1193335697
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] MichaelDeSteven closed issue #11130: [Improvement] Refactor dolphinscheduler-alert module
Posted by GitBox <gi...@apache.org>.
MichaelDeSteven closed issue #11130: [Improvement] Refactor dolphinscheduler-alert module
URL: https://github.com/apache/dolphinscheduler/issues/11130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org