You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/15 18:15:04 UTC
[jira] [Commented] (KAFKA-5248) Remove retention time from
TxnOffsetCommit RPC
[ https://issues.apache.org/jira/browse/KAFKA-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011027#comment-16011027 ]
ASF GitHub Bot commented on KAFKA-5248:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/3058
KAFKA-5248: Remove unused/unneeded retention time in TxnOffsetCommitRequest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-5248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3058.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3058
----
commit 9290f30b60d1264697494aaacda2d485ee6b237c
Author: Jason Gustafson <ja...@confluent.io>
Date: 2017-05-15T18:13:11Z
KAFKA-5248: Remove unused/unneeded retention time in TxnOffsetCommitRequest
----
> Remove retention time from TxnOffsetCommit RPC
> ----------------------------------------------
>
> Key: KAFKA-5248
> URL: https://issues.apache.org/jira/browse/KAFKA-5248
> Project: Kafka
> Issue Type: Sub-task
> Components: clients, core, producer
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
> Fix For: 0.11.0.0
>
>
> We added offset retention time because OffsetCommitRequest had it. However, the new consumer has never exposed this and we have no plan of exposing it in the producer, so we may as well remove it. If we need it later, we can bump the protocol.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)