You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/09 05:45:39 UTC
[PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
aglinxinyuan opened a new pull request, #8463:
URL: https://github.com/apache/texera/pull/8463
### What changes were proposed in this PR?
Deletes `UserWorkflowListItemComponent`, which is declared in `AppModule` but whose selector `texera-user-workflow-list-item` appears in no template — so it is never rendered. `HighlightSearchTermsPipe` goes with it, because the component's own template is the pipe's last remaining consumer. Pure deletion, no behaviour change: **−1,104 lines**.
### History
| | |
| --- | --- |
| **Introduced by** | #1937 (2023-05-30) — "Refactored each workflow list item into its own component" |
| **Usage removed by** | #2793 (2024-08-20) — "Generalize List Item" replaced it with the generic `ListItemComponent`, deleting the last two `texera-user-workflow-list-item` uses from `search-results.component.html` |
Dead for about two years.
> Reviewer note — why the pipe is in the same PR. `HighlightSearchTermsPipe` arrived in #2386 and kept a second consumer until #7463 (2026-08-29, "remove the deprecated project feature") dropped `entry.name | highlightSearchTerms` from that template. Since then its only use is this dead component's template (L43/L106). Removing the component alone would leave the pipe dead in the same commit, so they ship together; splitting them would just create a second PR for code this one already orphans.
> Nothing else needs cleaning: `WorkflowExecutionHistoryComponent`, `ShareAccessComponent`, `DownloadService`, `GuiConfigService` and `WorkflowPersistService` all keep other consumers.
### Any related issues, documentation, discussions?
Closes #8460
### How was this PR tested?
Existing tests only — this PR removes a component, a pipe, and the two specs that covered them.
From `frontend/`:
- `npx ng build` — **success**. This is the gate that matters here: removing an `AppModule` declaration can only be proven safe by an AOT build, since template diagnostics are AOT-only. A leftover use of either selector would fail it.
- `npx ng test --watch=false --include='**/user-workflow.component.spec.ts'` — 75 tests pass after dropping the two inert `TestBed` references.
- `yarn --cwd frontend format:ci` — clean.
Verification, re-runnable by a reviewer:
```
git grep -n "texera-user-workflow-list-item\|UserWorkflowListItemComponent"
git grep -n "highlightSearchTerms\|HighlightSearchTermsPipe"
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8463:
URL: https://github.com/apache/texera/pull/8463#issuecomment-5596487569
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@tanishqgandhi1908`
You can notify them by mentioning `@tanishqgandhi1908` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8463:
URL: https://github.com/apache/texera/pull/8463#issuecomment-5596643016
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8463?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.92%. Comparing base ([`bda3400`](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ab35bc6`](https://app.codecov.io/gh/apache/texera/commit/ab35bc613ecf4ac5f378f9d20103df15788e3137?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8463 +/- ##
============================================
- Coverage 93.94% 93.92% -0.03%
Complexity 4826 4826
============================================
Files 1209 1206 -3
Lines 49705 49584 -121
Branches 6074 6063 -11
============================================
- Hits 46694 46570 -124
- Misses 1522 1524 +2
- Partials 1489 1490 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.18% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.91% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.05% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.12% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.65% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.74% <ø> (-0.04%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8463/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [bda3400](https://app.codecov.io/gh/apache/texera/commit/bda3400261d38e674086f3b44cfcae169ccc55e5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8463?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #8463:
URL: https://github.com/apache/texera/pull/8463#discussion_r4058951466
##########
frontend/src/app/app.module.ts:
##########
@@ -330,15 +328,13 @@ registerLocaleData(en);
CollabWrapperComponent,
AboutComponent,
TexeraLoginComponent,
- UserWorkflowListItemComponent,
SortButtonComponent,
FiltersComponent,
FiltersInstructionsComponent,
SearchComponent,
PortPropertyEditFrameComponent,
WorkflowRuntimeStatisticsComponent,
FlarumComponent,
- HighlightSearchTermsPipe,
SearchBarComponent,
ListItemComponent,
Review Comment:
**Advisory:**
The cleanup stops one file short. `dashboard/component/section-style.scss:130-199` sits under the comment "css specifically for each workflow item in the list". It holds `.workflow-list-item` and everything nested under it, plus the `.metadata-container` rules at `:123` and `:213`. Base-tree grep shows the deleted `user-workflow-list-item.component.html` was the sole applier of every one of those classes. That leaves roughly 70 dead lines in a partial seven component stylesheets `@use`. Dead CSS renders nothing, so no behavior is wrong either way, but it is the same deletion, and leaving it means the next person redoes this grep. One dangling reference goes with it: `search-results.component.html:27` cites `.workflow-list-item` as the authority for `itemSize="70"`, already stale since #2793.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8463:
URL: https://github.com/apache/texera/pull/8463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #8463:
URL: https://github.com/apache/texera/pull/8463#discussion_r4089497349
##########
frontend/src/app/app.module.ts:
##########
@@ -330,15 +328,13 @@ registerLocaleData(en);
CollabWrapperComponent,
AboutComponent,
TexeraLoginComponent,
- UserWorkflowListItemComponent,
SortButtonComponent,
FiltersComponent,
FiltersInstructionsComponent,
SearchComponent,
PortPropertyEditFrameComponent,
WorkflowRuntimeStatisticsComponent,
FlarumComponent,
- HighlightSearchTermsPipe,
SearchBarComponent,
ListItemComponent,
Review Comment:
Applied in 45db957744 — `section-style.scss` loses the `.workflow-list-item` block with everything nested under it, plus both `.metadata-container` rules (the one nested in `.section-list-container` at `:123` and the top-level one at `:213`). The "including css shared by workflow/file item" line in the `.section-list-container` header goes with them, since `.metadata-container` was the only item-level rule under it.
`search-results.component.scss:128` held a third `.metadata-container` copy. It was dead even before this PR, because emulated encapsulation kept it from reaching the child component's DOM. That copy is out too, so `git grep metadata-container` now returns nothing. The `search-results.component.html:27` comment now cites `.list-item-card` in `list-item.component.scss`, the rule that sets the row height `itemSize="70"` approximates, instead of `.workflow-list-item`.
I merged `main` in first, since #8005 had added the resource-row rules to `section-style.scss` in the meantime. `ng build` passes, and the search-results + user-workflow specs are green (107 tests).
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the unused UserWorkflowListItemComponent [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #8463:
URL: https://github.com/apache/texera/pull/8463#issuecomment-5806953817
@Ma77Ball good catch — the global `.highlight-search-terms` rule in `styles.scss` and its "due to innerHTML" comment are gone in 45db957744. The pipe was the only thing that ever emitted that class, and after this PR a repo-wide `git grep highlight-search-terms` returns nothing. The description now has a note covering the CSS this PR removes, so "Nothing else needs cleaning" holds again.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org