You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Alexey Goncharuk <al...@gmail.com> on 2016/02/24 01:47:49 UTC

PR review

Folks,

Can I get a review of pull requests 508 [1] and 509 [2]  for Jira tickets
2707 [3] and 2709 [4] respectively? The changes are quite small, TC looks
ok.

Thanks,
AG

[1] https://github.com/apache/ignite/pull/508
[2] https://github.com/apache/ignite/pull/509
[3] https://issues.apache.org/jira/browse/IGNITE-2707
[4] https://issues.apache.org/jira/browse/IGNITE-2709

Re: PR review

Posted by Alexey Goncharuk <al...@gmail.com>.

Thanks, Semyon!

I've addressed the comments.

Re: PR review

Posted by Semyon Boikov <sb...@gridgain.com>.

Hi Alexey,

I reviewed your changes, added comments in tickets.

Semyon

On Wed, Feb 24, 2016 at 3:47 AM, Alexey Goncharuk <
alexey.goncharuk@gmail.com> wrote:

> Folks,
>
> Can I get a review of pull requests 508 [1] and 509 [2]  for Jira tickets
> 2707 [3] and 2709 [4] respectively? The changes are quite small, TC looks
> ok.
>
> Thanks,
> AG
>
> [1] https://github.com/apache/ignite/pull/508
> [2] https://github.com/apache/ignite/pull/509
> [3] https://issues.apache.org/jira/browse/IGNITE-2707
> [4] https://issues.apache.org/jira/browse/IGNITE-2709
>