You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2022/04/03 15:25:29 UTC

[kudu-CR] [tablet-copy] Simple refactor on tablet copy service.{h,cc,-test.cc}

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18379


Change subject: [tablet-copy] Simple refactor on tablet_copy_service.{h,cc,-test.cc}
......................................................................

[tablet-copy] Simple refactor on tablet_copy_service.{h,cc,-test.cc}

There is no functional changes in this patch, but only code style
related changes.

Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
---
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
3 files changed, 23 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/18379/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Gerrit-Change-Number: 18379
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tablet-copy] Simple refactor on tablet copy service.{h,cc,-test.cc}

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18379 )

Change subject: [tablet-copy] Simple refactor on tablet_copy_service.{h,cc,-test.cc}
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18379/1/src/kudu/tserver/tablet_copy_service.cc
File src/kudu/tserver/tablet_copy_service.cc:

http://gerrit.cloudera.org:8080/#/c/18379/1/src/kudu/tserver/tablet_copy_service.cc@370
PS1, Line 370: Status TabletCopyServiceImpl::ValidateFetchRequestDataId(
> warning: method 'ValidateFetchRequestDataId' can be made static [readabilit
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Gerrit-Change-Number: 18379
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sun, 03 Apr 2022 15:30:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tablet-copy] Simple refactor on tablet copy service{.h,.cc,-test.cc}

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18379 )

Change subject: [tablet-copy] Simple refactor on tablet_copy_service{.h,.cc,-test.cc}
......................................................................

[tablet-copy] Simple refactor on tablet_copy_service{.h,.cc,-test.cc}

There is no functional changes in this patch, but only code style
related changes.

Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Reviewed-on: http://gerrit.cloudera.org:8080/18379
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
3 files changed, 24 insertions(+), 26 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Gerrit-Change-Number: 18379
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tablet-copy] Simple refactor on tablet copy service.{h,cc,-test.cc}

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18379

to look at the new patch set (#2).

Change subject: [tablet-copy] Simple refactor on tablet_copy_service.{h,cc,-test.cc}
......................................................................

[tablet-copy] Simple refactor on tablet_copy_service.{h,cc,-test.cc}

There is no functional changes in this patch, but only code style
related changes.

Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
---
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
3 files changed, 24 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/18379/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Gerrit-Change-Number: 18379
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tablet-copy] Simple refactor on tablet copy service{.h,.cc,-test.cc}

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18379 )

Change subject: [tablet-copy] Simple refactor on tablet_copy_service{.h,.cc,-test.cc}
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Gerrit-Change-Number: 18379
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Apr 2022 16:36:38 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet-copy] Simple refactor on tablet copy service{.h,.cc,-test.cc}

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18379

to look at the new patch set (#3).

Change subject: [tablet-copy] Simple refactor on tablet_copy_service{.h,.cc,-test.cc}
......................................................................

[tablet-copy] Simple refactor on tablet_copy_service{.h,.cc,-test.cc}

There is no functional changes in this patch, but only code style
related changes.

Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
---
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
3 files changed, 24 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/18379/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1f4fd31cf3b217e604b565165a04efa017d19d2
Gerrit-Change-Number: 18379
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>