You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 14:30:25 UTC

[GitHub] [airflow] mhenc commented on pull request #25935: Support multiple DagProcessors parsing files from different locations.

mhenc commented on PR #25935:
URL: https://github.com/apache/airflow/pull/25935#issuecomment-1234363724

   
   
   
   > A thought: I'm not sure that `dag_directory` is the "right" name for the column on the model(s).
   > 
   > If I hadn't seen this PR then I'd expect a `dag_directory` column to be the something like the path to the dag with in the DAGS_FOLDER, (i.e.` dags/a/b/my_dag.py` would have a dag_directory of `a/b/`).
   > 
   > How about calling the column something like `processor_subdir` instead?
   
   I wanted it to be consistent with DagProcessoManager.dag_directory (as we get that value from there), but I see your point - and renamed to processor_subdir.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org