You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/10 20:45:52 UTC
[GitHub] dongjoon-hyun commented on issue #23610: [SPARK-26684]Add logs when
allocating large memory for PooledByteBufAllocator
dongjoon-hyun commented on issue #23610: [SPARK-26684]Add logs when allocating large memory for PooledByteBufAllocator
URL: https://github.com/apache/spark/pull/23610#issuecomment-462170557
Hi, @liupc . Thank you for your first contribution.
Good log is essential for all analysis. However, this is not a Spark specific issue. This is a little overkill if all `Netty`-based projects do this. Could you contribute to `Netty` project itself? Inside `Netty` project, it is one liner for each functions, isn't it?
- https://github.com/netty/netty/blob/4.1/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java#L321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org