You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/10 07:05:35 UTC
[GitHub] [nifi] wanghongqi opened a new pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
wanghongqi opened a new pull request #4326:
URL: https://github.com/apache/nifi/pull/4326
NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-7519
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4326:
URL: https://github.com/apache/nifi/pull/4326#issuecomment-641988724
The unit tests are failing during the GitHub Actions checks. You ran the build with the unit tests locally and these passed? It seems that `NullPointerExceptions` are being thrown.
```
[ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0.38 s <<< FAILURE! - in org.apache.nifi.record.sink.db.DatabaseRecordSinkTest
[ERROR] testRecordFormat(org.apache.nifi.record.sink.db.DatabaseRecordSinkTest) Time elapsed: 0.31 s <<< ERROR!
java.lang.NullPointerException
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.initTask(DatabaseRecordSinkTest.groovy:314)
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.testRecordFormat(DatabaseRecordSinkTest.groovy:110)
[ERROR] testMissingField(org.apache.nifi.record.sink.db.DatabaseRecordSinkTest) Time elapsed: 0.007 s <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.io.IOException> but was<java.lang.NullPointerException>
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.initTask(DatabaseRecordSinkTest.groovy:314)
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.testMissingField(DatabaseRecordSinkTest.groovy:199)
[ERROR] testMissingTable(org.apache.nifi.record.sink.db.DatabaseRecordSinkTest) Time elapsed: 0.013 s <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.io.IOException> but was<java.lang.NullPointerException>
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.initTask(DatabaseRecordSinkTest.groovy:314)
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.testMissingTable(DatabaseRecordSinkTest.groovy:180)
[ERROR] testMissingColumn(org.apache.nifi.record.sink.db.DatabaseRecordSinkTest) Time elapsed: 0.014 s <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.io.IOException> but was<java.lang.NullPointerException>
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.initTask(DatabaseRecordSinkTest.groovy:314)
at org.apache.nifi.record.sink.db.DatabaseRecordSinkTest.testMissingColumn(DatabaseRecordSinkTest.groovy:233)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] wanghongqi commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
wanghongqi commented on pull request #4326:
URL: https://github.com/apache/nifi/pull/4326#issuecomment-641867151
I'm not change about github checks error.
I run this check successful on my compute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4326:
URL: https://github.com/apache/nifi/pull/4326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] KuKuDeCheng commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
KuKuDeCheng commented on pull request #4326:
URL: https://github.com/apache/nifi/pull/4326#issuecomment-658667516
> I'm not change about github checks error.
> I run this check successful on my compute.
You need update DatabaseRecordSinkTest.java. Add your ExecuteSQL property like this:
`
when(dbContext.getProperty(DATABASE_URL)).thenReturn(new MockPropertyValue("jdbc:derby:${DB_LOCATION}"))
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] wanghongqi commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
wanghongqi commented on pull request #4326:
URL: https://github.com/apache/nifi/pull/4326#issuecomment-642940050
I retry the unit tests and not error!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4326:
URL: https://github.com/apache/nifi/pull/4326#issuecomment-826170765
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4326:
URL: https://github.com/apache/nifi/pull/4326#issuecomment-826170765
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org