[GitHub] [calcite] NobiGo commented on a change in pull request #2620: [CALCITE-4907] JdbcJoin does not convert Join with always true/false …

[GitBox <gi...@apache.org>]

NobiGo commented on a change in pull request #2620:
URL: https://github.com/apache/calcite/pull/2620#discussion_r759737227



##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -332,6 +332,9 @@ protected JdbcJoinRule(Config config) {
      * @return Whether condition is supported
      */
     private static boolean canJoinOnCondition(RexNode node) {
+      if (node.isAlwaysTrue() || node.isAlwaysFalse()) {
+        return true;
+      }

Review comment:
       Add another case condition:
   ```
   // ***************
   case LITERAL:
           return true;
   ```
   is more suitable ? 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org