You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/03/17 11:19:58 UTC
[GitHub] [libcloud] karantan opened a new pull request #1571: Fix NSOne DNS Provider
karantan opened a new pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571
## Fix NSOne DNS Provider
### Description
- handle mx records
- handle root domain
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1571: Fix NSOne DNS Provider
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571#issuecomment-820329561
Thanks for the contribution and sorry for the delay.
The change looks good to me, but it would be great if you could add corresponding unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on a change in pull request #1571: Fix NSOne DNS Provider
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571#discussion_r624757549
##########
File path: libcloud/dns/drivers/nsone.py
##########
@@ -206,7 +206,7 @@ def delete_record(self, record):
return response.status == httplib.OK
- def create_record(self, name, zone, type, data, extra=None):
+ def create_record(self, name, zone, type_, data, extra=None):
Review comment:
``type`` argument is part of the standard API (aka is the same for all the provider drivers) so we should use it here as well.
I know it's not ideal since it clashes with a built-int value, but not much we can do at this point (besides changing the standard API + updating all the drivers in the future).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] asfgit merged pull request #1571: Fix NSOne DNS Provider
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] karantan commented on pull request #1571: Fix NSOne DNS Provider
Posted by GitBox <gi...@apache.org>.
karantan commented on pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571#issuecomment-831060026
hey, sorry for the delay. I was busy with other things ... anyway I added 3 tests and renamed `type_` back to `type`. do we need to do anything else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on a change in pull request #1571: Fix NSOne DNS Provider
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1571:
URL: https://github.com/apache/libcloud/pull/1571#discussion_r624757628
##########
File path: libcloud/dns/drivers/nsone.py
##########
@@ -206,7 +206,7 @@ def delete_record(self, record):
return response.status == httplib.OK
- def create_record(self, name, zone, type, data, extra=None):
+ def create_record(self, name, zone, type_, data, extra=None):
Review comment:
Besides that, changes look good to me - please just add some tests when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org