You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/04/29 02:43:34 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #1941: [CALCITE-3952] Improve SortRemoveRule to remove Sort based on rowcount (Vineet Garg)

chunweilei commented on a change in pull request #1941:
URL: https://github.com/apache/calcite/pull/1941#discussion_r417037019



##########
File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java
##########
@@ -143,6 +143,14 @@ public abstract Sort copy(RelTraitSet traitSet, RelNode newInput,
     return fieldExps;
   }
 
+  public RexNode getFetch() {
+    return fetch;
+  }
+
+  public RexNode getOffset() {
+    return offset;
+  }

Review comment:
       Both `fetch` and `offset` are public. So it seems not necessary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org