You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2017/03/30 03:29:40 UTC
Review Request 58054: Sort the set objects inside TaskConfig during
Job diff.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1913
https://issues.apache.org/jira/browse/AURORA-1913
Repository: aurora
Description
-------
Sort the entires in `set` fields inside `TaskConfig` as strings before
shelling out to diff so that the output is consistent and meaningful.
Diffs
-----
src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00
src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314
src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649
Diff: https://reviews.apache.org/r/58054/diff/1/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 58054: Sort the set objects inside TaskConfig
during Job diff.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/#review170516
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/diff_formatter.py
Line 55 (original), 55 (patched)
<https://reviews.apache.org/r/58054/#comment243369>
Please leave a comment that we are sorting sets here for consistency.
- Zameer Manji
On March 29, 2017, 8:29 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58054/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 8:29 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1913
> https://issues.apache.org/jira/browse/AURORA-1913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Sort the entires in `set` fields inside `TaskConfig` as strings before
> shelling out to diff so that the output is consistent and meaningful.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314
> src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649
>
>
> Diff: https://reviews.apache.org/r/58054/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58054: Sort the set objects inside TaskConfig
during Job diff.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/#review170529
-----------------------------------------------------------
Ship it!
Master (3a9aabd) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 30, 2017, 4:55 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58054/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 4:55 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1913
> https://issues.apache.org/jira/browse/AURORA-1913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Sort the entires in `set` fields inside `TaskConfig` as strings before
> shelling out to diff so that the output is consistent and meaningful.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314
> src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649
>
>
> Diff: https://reviews.apache.org/r/58054/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58054: Sort the set objects inside TaskConfig
during Job diff.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/
-----------------------------------------------------------
(Updated March 29, 2017, 9:55 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
Style fixes, feedback.
Bugs: AURORA-1913
https://issues.apache.org/jira/browse/AURORA-1913
Repository: aurora
Description
-------
Sort the entires in `set` fields inside `TaskConfig` as strings before
shelling out to diff so that the output is consistent and meaningful.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00
src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314
src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649
Diff: https://reviews.apache.org/r/58054/diff/2/
Changes: https://reviews.apache.org/r/58054/diff/1-2/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 58054: Sort the set objects inside TaskConfig
during Job diff.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58054/#review170519
-----------------------------------------------------------
Master (3a9aabd) is red with this patch.
./build-support/jenkins/build.sh
Running setup.py bdist_wheel for twitter.common.options: finished with status 'done'
Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/17/41/80/c4811d8c1c7ca7007e520c3399872fc340f45c3a26a6a23e6a
Successfully built pantsbuild.pants twitter.common.collections setproctitle ansicolors pathspec scandir twitter.common.dirutil psutil pystache docutils Markdown Pygments twitter.common.confluence coverage lmdb pywatchman twitter.common.lang twitter.common.log pycparser twitter.common.options
Installing collected packages: twitter.common.lang, twitter.common.collections, setproctitle, setuptools, six, ansicolors, pyparsing, packaging, pathspec, scandir, twitter.common.dirutil, psutil, requests, pystache, pex, docutils, Markdown, Pygments, twitter.common.options, twitter.common.log, twitter.common.confluence, monotonic, fasteners, coverage, pycparser, cffi, lmdb, pywatchman, futures, pantsbuild.pants
Found existing installation: setuptools 21.2.1
Uninstalling setuptools-21.2.1:
Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cffi-1.7.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89 monotonic-1.3 packaging-16.7 pantsbuild.pants-1.3.0.dev3 pathspec-0.3.4 pex-1.1.16 psutil-4.3.0 pycparser-2.17 pyparsing-2.2.0 pystache-0.5.3 pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 setuptools-30.0.0 six-1.10.0 twitter.common.collections-0.3.9 twitter.common.confluence-0.3.9 twitter.common.dirutil-0.3.9 twitter.common.lang-0.3.9 twitter.common.log-0.3.9 twitter.common.options-0.3.9
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
03:37:25 00:00 [main]
(To run a reporting server: ./pants server)
03:37:25 00:00 [setup]
03:37:25 00:00 [parse][32m
Executing tasks in goals: compile[0m
03:37:25 00:00 [compile]
03:37:25 00:00 [compile-prep-command]
03:37:25 00:00 [prep_command]
03:37:27 00:02 [compile]
03:37:27 00:02 [python-eval]
03:37:27 00:02 [pythonstyle]
03:37:28 00:03 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
F401:ERROR src/test/python/apache/aurora/client/cli/test_diff_formatter.py:015 'contextlib' imported but unused
|import contextlib
F401:ERROR src/test/python/apache/aurora/client/cli/test_diff_formatter.py:016 'os' imported but unused
|import os
F401:ERROR src/test/python/apache/aurora/client/cli/test_diff_formatter.py:021 'patch' imported but unused
|from mock import Mock, call, patch
FAILURE: 3 Python Style issues found. For import order related issues, please try `./pants fmt.isort <targets>`
03:37:51 00:26 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 30, 2017, 3:29 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58054/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 3:29 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1913
> https://issues.apache.org/jira/browse/AURORA-1913
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Sort the entires in `set` fields inside `TaskConfig` as strings before
> shelling out to diff so that the output is consistent and meaningful.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/diff_formatter.py a1b9bb3086b277e5da6d21496879a7aca8299e00
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py a145d8846f65ba222d7fd3f91bf9109a50f26314
> src/test/python/apache/aurora/client/cli/util.py c65ae75c680ec4ca4e4d2a398c80e73ddff16649
>
>
> Diff: https://reviews.apache.org/r/58054/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>