You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2023/07/18 09:28:04 UTC

[PR] Docs: Minor change missed in #14590 (druid)

kfaraz opened a new pull request, #14604:
URL: https://github.com/apache/druid/pull/14604

   Minor change missed in #14590 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Docs: Minor change missed in #14590 (druid)

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz closed pull request #14604: Docs: Minor change missed in #14590
URL: https://github.com/apache/druid/pull/14604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Docs: Minor change missed in #14590 (druid)

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz closed pull request #14604: Docs: Minor change missed in #14590
URL: https://github.com/apache/druid/pull/14604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Docs: Minor change missed in #14590 (druid)

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #14604:
URL: https://github.com/apache/druid/pull/14604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Docs: Minor change missed in #14590 (druid)

Posted by "writer-jill (via GitHub)" <gi...@apache.org>.
writer-jill commented on code in PR #14604:
URL: https://github.com/apache/druid/pull/14604#discussion_r1266506447


##########
docs/configuration/index.md:
##########
@@ -967,9 +967,9 @@ Issuing a GET request at the same URL will return the spec that is currently in
 ##### Smart segment loading
 
 The `smartSegmentLoading` mode simplifies Coordinator configuration for segment loading and balancing.
-In this mode, the Coordinator does not require the user to provide values of the following parameters and computes them automatically instead.
-> If you enable `smartSegmentLoading` mode **and** provide values for the following properties, Druid ignores your values. The Coordinator computes them automatically.
-The computed values are based on the current state of the cluster and are designed to optimize Coordinator performance.
+If you enable this mode, do not provide values for the properties in the table below as the Coordinator computes them automatically.
+The values are computed based on the current state of the cluster and are designed to optimize Coordinator performance.

Review Comment:
   ```suggestion
   Druid computes the values to optimize Coordinator performance, based on the current state of the cluster.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org