You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/04/23 01:30:25 UTC
[GitHub] [openmeetings] solomax commented on a change in pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream
solomax commented on a change in pull request #65:
URL: https://github.com/apache/openmeetings/pull/65#discussion_r413443529
##########
File path: openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
##########
@@ -120,7 +121,8 @@ public void init() {
try {
kuid = randomUUID().toString();
client = KurentoClient.create(kurentoWsUrl, new KConnectionListener(kuid));
- client.getServerManager().addObjectCreatedListener(new KWatchDog());
+ client.getServerManager().addObjectCreatedListener(new KWatchDogCreate());
+ client.getServerManager().addObjectDestroyedListener(new KWatchDogDestroy());
Review comment:
We are not relying on browser events already
https://github.com/apache/openmeetings/blob/master/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java#L123
The stream should both be stopped and destroyed
I would further investigate why it is not happening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org