You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/21 17:57:24 UTC
Review Request: Added some helpers for failing a collection of futures.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11311/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
#11311!
Diffs
-----
third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
Diff: https://reviews.apache.org/r/11311/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added some helpers for failing a collection of futures.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 21, 2013, 10:30 p.m., Vinod Kone wrote:
> > third_party/libprocess/include/process/future.hpp, line 454
> > <https://reviews.apache.org/r/11311/diff/1/?file=295248#file295248line454>
> >
> > s/vector/promises/
Great, thanks.
> On May 21, 2013, 10:30 p.m., Vinod Kone wrote:
> > third_party/libprocess/include/process/future.hpp, line 465
> > <https://reviews.apache.org/r/11311/diff/1/?file=295248#file295248line465>
> >
> > s/list/promises/
Indeed.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11311/#review20872
-----------------------------------------------------------
On May 21, 2013, 3:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11311/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:57 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> #11311!
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
>
> Diff: https://reviews.apache.org/r/11311/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some helpers for failing a collection of futures.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11311/#review20872
-----------------------------------------------------------
third_party/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/11311/#comment42978>
s/vector/promises/
third_party/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/11311/#comment42977>
s/list/promises/
- Vinod Kone
On May 21, 2013, 3:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11311/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:57 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> #11311!
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
>
> Diff: https://reviews.apache.org/r/11311/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some helpers for failing a collection of futures.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11311/#review21033
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 21, 2013, 3:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11311/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:57 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> #11311!
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
>
> Diff: https://reviews.apache.org/r/11311/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some helpers for failing a collection of futures.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11311/#review21341
-----------------------------------------------------------
Just commenting as I go through my review backlog:
Seems like this could be one template for a generic container that supports .begin() / .end() iteration, instead of one template per container type.
- Ben Mahler
On May 21, 2013, 3:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11311/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:57 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> #11311!
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7
>
> Diff: https://reviews.apache.org/r/11311/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>