You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2012/09/28 22:11:17 UTC

@Override and @Deprecated

Hi All:

Shouldn't we add @Override and @Deprecated where they are missing?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: @Override and @Deprecated

Posted by Gary Gregory <ga...@gmail.com>.
I've added @Override (at the Java 5 level) and @Deprecated where needed.

Gary

On Fri, Sep 28, 2012 at 4:28 PM, Ralph Goers <ra...@dslextreme.com>wrote:

> Yes.  I admit I am not terribly good at always using @Override where I
> should.
>
> Ralph
>
> On Sep 28, 2012, at 1:11 PM, Gary Gregory wrote:
>
> Hi All:
>
> Shouldn't we add @Override and @Deprecated where they are missing?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977/>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: @Override and @Deprecated

Posted by Ralph Goers <ra...@dslextreme.com>.
Yes.  I admit I am not terribly good at always using @Override where I should.

Ralph

On Sep 28, 2012, at 1:11 PM, Gary Gregory wrote:

> Hi All:
> 
> Shouldn't we add @Override and @Deprecated where they are missing?
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Re: @Override and @Deprecated

Posted by Ralph Goers <ra...@dslextreme.com>.
I require Java 6.  So far, I've not had a reason to not support Java 5.  I've been able to take advantage of Java 6 and 7 through reflection and tested that there isn't a significant performance difference by running ReflectionComparison.

Running org.apache.logging.log4j.ReflectionComparison
Timer Reflection stopped. Elapsed time: 0.719909000 seconds Average per iteration: 0.000000719 seconds
Timer Reflection stopped. Elapsed time: 0.613188000 seconds Average per iteration: 0.000000613 seconds
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.412 sec

Other methods might be different of course. ThrowableProxy does the same thing to support for suppressed exceptions when running in Java 7.

Ralph


On Sep 28, 2012, at 1:59 PM, Gary Gregory wrote:

> Log4J 2.0 is for Java 1.5 ATM.
> 
> It would be fine with my (personal and work projects) if the req was Java 6 or even 7.
> 
> Gary
> 
> On Fri, Sep 28, 2012 at 4:18 PM, Paul Benedict <pb...@apache.org> wrote:
> What's the Java source/target? Remember, @Override can only be applied to implementations of interfaces in Java 6.
> 
> Paul
> 
> 
> On Fri, Sep 28, 2012 at 3:11 PM, Gary Gregory <ga...@gmail.com> wrote:
> Hi All:
> 
> Shouldn't we add @Override and @Deprecated where they are missing?
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Re: @Override and @Deprecated

Posted by Gary Gregory <ga...@gmail.com>.
Log4J 2.0 is for Java 1.5 ATM.

It would be fine with my (personal and work projects) if the req was Java 6
or even 7.

Gary

On Fri, Sep 28, 2012 at 4:18 PM, Paul Benedict <pb...@apache.org> wrote:

> What's the Java source/target? Remember, @Override can only be applied to
> implementations of interfaces in Java 6.
>
> Paul
>
>
> On Fri, Sep 28, 2012 at 3:11 PM, Gary Gregory <ga...@gmail.com>wrote:
>
>> Hi All:
>>
>> Shouldn't we add @Override and @Deprecated where they are missing?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: @Override and @Deprecated

Posted by Paul Benedict <pb...@apache.org>.
What's the Java source/target? Remember, @Override can only be applied to
implementations of interfaces in Java 6.

Paul

On Fri, Sep 28, 2012 at 3:11 PM, Gary Gregory <ga...@gmail.com>wrote:

> Hi All:
>
> Shouldn't we add @Override and @Deprecated where they are missing?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>