You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lukasz Lenart (JIRA)" <ji...@apache.org> on 2013/06/06 07:34:25 UTC

[jira] [Updated] (WW-4094) struts.allowed.action.names inconsistency

     [ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart updated WW-4094:
------------------------------

    Description: 
I think there is a inconsistency in DefaultActionMapper.cleanupActionName

According to http://struts.apache.org/development/2.x/docs/s2-015.html struts.allowed.action.names defines a regex the action name must match.

The default regex is: {{[a-z]*[A-Z]*[0-9]*[.\-_!/]*}}

I have an action with the name "core_blz"

This action name does not match the regex (underscore is not at the end)(maybe the default value should be changed).

{{DefaultActionMapper reports Action [#0] do not match allowed action names pattern [#1], cleaning it up!}}

But the cleaned action name is still core_blz.

If this function is only to remove suspicious characters, then the warning should not be displayed.



  was:
I think there is a inconsistency in DefaultActionMapper.cleanupActionName

According to http://struts.apache.org/development/2.x/docs/s2-015.html struts.allowed.action.names defines a regex the action name must match.

The default regex is: [a-z]*[A-Z]*[0-9]*[.\-_!/]*

I have an action with the name "core_blz"

This action name does not match the regex (underscore is not at the end)(maybe the default value should be changed).

DefaultActionMapper reports Action [#0] do not match allowed action names pattern [#1], cleaning it up!

But the cleaned action name is still core_blz.

If this function is only to remove suspicious characters, then the warning should not be displayed.



    
> struts.allowed.action.names inconsistency
> -----------------------------------------
>
>                 Key: WW-4094
>                 URL: https://issues.apache.org/jira/browse/WW-4094
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.14.3
>            Reporter: Andreas Sachs
>            Priority: Minor
>
> I think there is a inconsistency in DefaultActionMapper.cleanupActionName
> According to http://struts.apache.org/development/2.x/docs/s2-015.html struts.allowed.action.names defines a regex the action name must match.
> The default regex is: {{[a-z]*[A-Z]*[0-9]*[.\-_!/]*}}
> I have an action with the name "core_blz"
> This action name does not match the regex (underscore is not at the end)(maybe the default value should be changed).
> {{DefaultActionMapper reports Action [#0] do not match allowed action names pattern [#1], cleaning it up!}}
> But the cleaned action name is still core_blz.
> If this function is only to remove suspicious characters, then the warning should not be displayed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira