You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2015/07/31 04:39:27 UTC
[GitHub] storm pull request: STORM-933:NullPointerException during KafkaSpo...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/660
STORM-933:NullPointerException during KafkaSpout deactivation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #660
----
commit 2a1a417f922cbce6239b5c85eb75363b92b9a2d0
Author: caofangkun <ca...@gmail.com>
Date: 2015-07-31T02:36:42Z
STORM-933:NullPointerException during KafkaSpout deactivation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-933:NullPointerException during KafkaSpo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-933:NullPointerException during KafkaSpo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/660#issuecomment-127075818
We can add null check from KafkaSpout.commit() to save tiny memory (by lazy allocation), but it is really tiny so I think current approach is acceptable.
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-933:NullPointerException during KafkaSpo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/660#issuecomment-127082994
I merged this into master, 0.10.x-branch, 0.9.x-branch respectively.
Seems like Github mirror has issue again. When it becomes stable, your PR could be automatically marked as merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---