You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Reza ardeshir rokni (Jira)" <ji...@apache.org> on 2020/05/15 03:19:00 UTC

[jira] [Created] (BEAM-10003) Need two PR to submit snippets to website

Reza ardeshir rokni created BEAM-10003:
------------------------------------------

             Summary: Need two PR to submit snippets to website
                 Key: BEAM-10003
                 URL: https://issues.apache.org/jira/browse/BEAM-10003
             Project: Beam
          Issue Type: New Feature
          Components: website
            Reporter: Reza ardeshir rokni


Looks like build_github_samples.sh uses code already on the repo to build local serving;

do
  fileName=$(echo "$url" | sed -e 's/\//_/g')
  curl -o "$DIST_DIR"/"$fileName" "[https://raw.githubusercontent.com|https://raw.githubusercontent.com/]$url"
done

So when tying to test locally, the code needs to have already be in Beam. 

Ideally the script should make use of local code when building so :

1- Easier to  build & test changes.
2- No need to raise two PR for what is a single change

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)