You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/11 15:47:34 UTC
[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #3069: [improve][e2e] Change the starter module from file copy to binding file path
ashulin opened a new pull request, #3069:
URL: https://github.com/apache/incubator-seatunnel/pull/3069
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
The start module file can be determined before the container is started and don‘t need to be copied.
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #3069: [improve][e2e] Change the starter module from file copy to binding file path
Posted by GitBox <gi...@apache.org>.
TyrantLucifer merged PR #3069:
URL: https://github.com/apache/incubator-seatunnel/pull/3069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3069: [improve][e2e] Change the starter module from file copy to binding file path
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #3069:
URL: https://github.com/apache/incubator-seatunnel/pull/3069#issuecomment-1276201216
Resolve conflicts please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3069: [improve][e2e] Change the starter module from file copy to binding file path
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #3069:
URL: https://github.com/apache/incubator-seatunnel/pull/3069#discussion_r992935216
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/SeaTunnelContainer.java:
##########
@@ -54,13 +52,15 @@ public class SeaTunnelContainer extends AbstractTestContainer {
public void startUp() throws Exception {
server = new GenericContainer<>(getDockerImage())
.withNetwork(NETWORK)
- .withCommand(Paths.get(SEATUNNEL_BIN, SERVER_SHELL).toString())
+ .withCommand(Paths.get(SEATUNNEL_HOME, "bin", SERVER_SHELL).toString())
.withNetworkAliases("server")
.withExposedPorts()
- .withLogConsumer(new Slf4jLogConsumer(LOG))
+ .withLogConsumer(new Slf4jLogConsumer(DockerLoggerFactory.getLogger("seatunnel-engine:" + LOG)))
Review Comment:
```suggestion
.withLogConsumer(new Slf4jLogConsumer(DockerLoggerFactory.getLogger("seatunnel-engine:" + JDK_DOCKER_IMAGE)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #3069: [improve][e2e] Change the starter module from file copy to binding file path
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #3069:
URL: https://github.com/apache/incubator-seatunnel/pull/3069#issuecomment-1276265916
@EricJoy2048 @Hisoka-X PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3069: [improve][e2e] Change the starter module from file copy to binding file path
Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3069:
URL: https://github.com/apache/incubator-seatunnel/pull/3069#issuecomment-1277640649
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org