[GitHub] spark pull request: [SPARK-14914] Skip some test cases on Windows ...

[taoli91 <gi...@git.apache.org>]

Github user taoli91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12696#discussion_r61840799
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -575,8 +575,13 @@ class SparkSubmitSuite
       // NOTE: This is an expensive operation in terms of time (10 seconds+). Use sparingly.
       private def runSparkSubmit(args: Seq[String]): Unit = {
         val sparkHome = sys.props.getOrElse("spark.test.home", fail("spark.test.home is not set!"))
    +    val sparkSubmit = if (Utils.isWindows) {
    +      Seq(new File("..\\bin\\spark-submit.cmd").getAbsolutePath) ++ args
    --- End diff --
    
    > The path here is different (starting with ..). Really the right way to do this is with `new File("./bin/spark-submit"), for non-Windows as well, optionally putting .cmd on the end for Windows.
    
    @srowen I've verified this. On windows, the working directory would be spark/core here. So `./bin/spark-submit` doesn't work here on windows. Further, it seems we have to add the `cmd` suffix, otherwise it will complain that it's not a valid win32 program. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org