You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/03/26 18:37:35 UTC
[kudu-CR](branch-1.7.x) [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
Hello Will Berkeley, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9802
to review the following change.
Change subject: [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
......................................................................
[master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
As Will noticed, the TestDumpStacksOnRpcQueueOverflow scenario always
fails on macOS since the stack trace dumping is not supported there.
This patch simply moves the TestDumpStacksOnRpcQueueOverflow scenario
under '#ifndef __APPLE__ ... #endif' macro.
This is a follow-up for 96b3b63a48c270a77819e6fc80d1dfdb381a0df7.
Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Reviewed-on: http://gerrit.cloudera.org:8080/9720
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit e391e8a9c2c92daab4124ab9d2c9803a8df6afd7)
---
M src/kudu/master/master-test.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/9802/1
--
To view, visit http://gerrit.cloudera.org:8080/9802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Gerrit-Change-Number: 9802
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9802 )
Change subject: [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Gerrit-Change-Number: 9802
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9802 )
Change subject: [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Gerrit-Change-Number: 9802
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:54:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9802 )
Change subject: [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
......................................................................
Patch Set 1: Verified+1
Build failure due to the following error:
libtool: Version mismatch error. This is libtool 2.4.2 Debian-2.4.2-1.7ubuntu1, but the definition of this LT_INIT comes from libtool 2.4.6.
Seems like some workspace issues?
There are also failures in a couple of unrelated tests. Anyway, I think it's safe to ignore this because it's unrelated to the change.
--
To view, visit http://gerrit.cloudera.org:8080/9802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Gerrit-Change-Number: 9802
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 20:04:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9802 )
Change subject: [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
......................................................................
[master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS
As Will noticed, the TestDumpStacksOnRpcQueueOverflow scenario always
fails on macOS since the stack trace dumping is not supported there.
This patch simply moves the TestDumpStacksOnRpcQueueOverflow scenario
under '#ifndef __APPLE__ ... #endif' macro.
This is a follow-up for 96b3b63a48c270a77819e6fc80d1dfdb381a0df7.
Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Reviewed-on: http://gerrit.cloudera.org:8080/9720
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit e391e8a9c2c92daab4124ab9d2c9803a8df6afd7)
Reviewed-on: http://gerrit.cloudera.org:8080/9802
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/master-test.cc
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e
Gerrit-Change-Number: 9802
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>