[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #689: HDDS-3183. Deprecate old Recon HTTP Server Keytab config key.
URL: https://github.com/apache/hadoop-ozone/pull/689#discussion_r394570555
 
 

 ##########
 File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ConfigurationProvider.java
 ##########
 @@ -32,10 +33,17 @@
 
   private static OzoneConfiguration configuration;
 
+  private static void addDeprecations() {
+    Configuration.addDeprecation(
+        ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE_OLD,
+        ReconServerConfigKeys.OZONE_RECON_HTTP_KEYTAB_FILE);
+  }
+
   @VisibleForTesting
   public static void setConfiguration(OzoneConfiguration conf) {
     if (configuration == null) {
       ConfigurationProvider.configuration = conf;
+      ConfigurationProvider.addDeprecations();
 
 Review comment:
   NIT: should we move this to a static block of the class to avoid issues like caller forget to invoke setConfiguration explicitly?
   
     static {
       addDeprecations();  
     }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org