You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/05 06:15:35 UTC
[GitHub] [incubator-kyuubi] ulysses-you opened a new issue, #3901: [Umbrella][KPIP-6] Introduce Trino frontend
ulysses-you opened a new issue, #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues) and found no similar issues.
### Describe the proposal
The main goal is: Support trino-driver and trino-client connect to Kyuubi server
Proposal: https://docs.google.com/document/d/1EQBvyrYGo-m845Kg-6jN_0jhBEdDnZ1XMWjQYXnta-I/edit?usp=sharing
### Task list
# source
- [x] Add basic TrinoResource
- [x] Compatiable with Trino rest dto
- [x] Compatiable with Trino query id, slug and token
- [x] Parse Trino http header
- [x] Add TrinoOperationAdapter map query statement to operation (see `io.trino.jdbc.TrinoDatabaseMetaData`)
- [x] get catalogs (SELECT TABLE_CAT FROM system.jdbc.catalogs)
- [x] get schemas (SELECT TABLE_SCHEM, TABLE_CATALOG FROM system.jdbc.schemas)
- [x] get tables (SELECT TABLE_CAT, TABLE_SCHEM, TABLE_NAME, TABLE_TYPE, REMARKS, TYPE_CAT, TYPE_SCHEM, TYPE_NAME, SELF_REFERENCING_COL_NAME, REF_GENERATION FROM system.jdbc.tables)
- [x] get columns
- [x] get functions
- [x] get table types
- [x] get primary keys
- [x] get cross reference
- [x] get type info
- [x] set client info
- [x] execute query
- [x] Support create query
- [x] Support get query status
- [x] Support delete query
# integration test
- [x] Add Trino-cli it
- [x] Add Trino-driver it
- [x] get catalogs
- [x] get schemas
- [x] get tables
- [x] get columns
- [x] get functions
- [x] get table types
- [x] get primary keys
- [x] get cross reference
- [x] get type info
- [x] set client info
- [x] execute query
# docs
- [x] Trino frontend quick start
- [x] The usage of Trino frontend
### Are you willing to submit PR?
- [ ] Yes. I can submit a PR independently to improve.
- [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
- [ ] No. I cannot submit a PR at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on issue #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901#issuecomment-1344105494
@yehere it depends on the scope of your pr. in general, ut is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on issue #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901#issuecomment-1336860779
cc @iodone @Yikf @yanghua @cxzl25 welcome to contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901#issuecomment-1343781433
the subtask of `Introduce antlr4 to parse query statement` seems to extend the scope of this umbrella a lot, do we need a design doc for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on issue #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901#issuecomment-1343787706
According to It's scope, it is actuall not the subtask of this umbrella .. What I expected is a pr just for parsing Trino statement and only used for something like `KyuubiTrinoSessionImpl`, not a custom precedure for Kyuubi server and something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on issue #3901:
URL: https://github.com/apache/kyuubi/issues/3901#issuecomment-1491567908
closed since almost issues have been solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you closed issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you closed issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
URL: https://github.com/apache/kyuubi/issues/3901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by GitBox <gi...@apache.org>.
iodone commented on issue #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901#issuecomment-1336861508
can you assign this issue to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yehere commented on issue #3901: [Umbrella][KPIP-6] Introduce Trino frontend
Posted by GitBox <gi...@apache.org>.
yehere commented on issue #3901:
URL: https://github.com/apache/incubator-kyuubi/issues/3901#issuecomment-1344103022
Is it necessary to supplement multi sql and test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org