You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/01/18 01:53:32 UTC
[GitHub] [buildstream] gtristan opened a new pull request #1570: tests/format/variables.py: Adding test for special "notparallel"
gtristan opened a new pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570
…vior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1570: tests/format/variables.py: Adding test for special "notparallel"
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570#issuecomment-1015871327
Is this really sufficient case to trigger the bug? Don't you need to have multiple elements, some of which are not parallel and some which are? I think @abderrahim was at least saying the issue is some variable is pre-expanded that shouldn't be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1570: tests/format/variables.py: Adding test for special "notparallel"
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570#issuecomment-1028722405
> > Is this really sufficient case to trigger the bug? Don't you need to have multiple elements, some of which are not parallel and some which are? I think @abderrahim was at least saying the issue is some variable is pre-expanded that shouldn't be.
>
> Not yet, no.
This has now been updated to properly trigger the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1570: Fix `MappingNode._composite()`
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1570: Fix `MappingNode._composite()`
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570#issuecomment-1028743500
And this merge request has now been updated to include both the test case and the fix for the underlying composition issue.
@BenjaminSchubert, can you take a look at this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1570: Fix `MappingNode._composite()`
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570#issuecomment-1028956706
We’ve got some kind of github bug, the CI actions appear to be randomly getting cancelled :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1570: tests/format/variables.py: Adding test for special "notparallel"
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570#issuecomment-1015871327
Is this really sufficient case to trigger the bug? Don't you need to have multiple elements, some of which are not parallel and some which are?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1570: tests/format/variables.py: Adding test for special "notparallel"
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1570:
URL: https://github.com/apache/buildstream/pull/1570#issuecomment-1015911860
> Is this really sufficient case to trigger the bug? Don't you need to have multiple elements, some of which are not parallel and some which are? I think @abderrahim was at least saying the issue is some variable is pre-expanded that shouldn't be.
Not yet, no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org