[jira] [Commented] (GEOMETRY-29) Plane API cleanup

["Matt Juntunen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809389#comment-16809389 ] 

Matt Juntunen commented on GEOMETRY-29:
---------------------------------------

This PR is looking good. [~erans], what do you think? I'd like your opinion on two things specifically:
1. To store or not to store the computed {{origin}} property?
2. Creation of {{Vector3D#areCoplanar()}} method; should this be part of the public API?

> Plane API cleanup
> -----------------
>
>                 Key: GEOMETRY-29
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-29
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>
> The following changes should be made to the {{o.a.c.g.euclidean.threed.Plane}} class:
>  * make the class immutable
>  * use well-named factory methods instead of constructor overloads
>  * provide a factory method to create a plane with user-supplied {{u}} and {{v}} axes. The current implementation allows the normal to be provided but chooses its own planar axes (see {{setFrame}}).
>  * add {{equals}}, {{hashCode}}, and {{toString}} methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)