You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by Nathan Hartman <ha...@gmail.com> on 2020/11/22 20:06:30 UTC

Mistake in comment describing USEC_PER_TICK?

Is there a mistake in the following comment in include/nuttx/clock.h?

[[[
/* If CONFIG_SCHED_TICKLESS is not defined, then the interrupt interval of
 * the system timer is given by USEC_PER_TICK.  This is the expected number
 * of microseconds between calls from the processor-specific logic to
 * nxsched_process_timer().  The default value of USEC_PER_TICK is 10000
 * microseconds (100KHz).  However, this default setting can be overridden
 * by defining the interval in microseconds as CONFIG_USEC_PER_TICK in the
]]]

The mistake: if USEC_PER_TICK is 10000 by default, that should be 100
Hz, not 100 KHz.

Did I find an error or did I miss something?

Nathan

Re: Mistake in comment describing USEC_PER_TICK?

Posted by Nathan Hartman <ha...@gmail.com>.
Thanks for confirming. I submitted PR #2378

Cheers,
Nathan

On Sun, Nov 22, 2020 at 5:15 PM Alan Carvalho de Assis <ac...@gmail.com>
wrote:

> You are right, it should be 100Hz instead 100KHz.
>
> On 11/22/20, Nathan Hartman <ha...@gmail.com> wrote:
> > Is there a mistake in the following comment in include/nuttx/clock.h?
> >
> > [[[
> > /* If CONFIG_SCHED_TICKLESS is not defined, then the interrupt interval
> of
> >  * the system timer is given by USEC_PER_TICK.  This is the expected
> number
> >  * of microseconds between calls from the processor-specific logic to
> >  * nxsched_process_timer().  The default value of USEC_PER_TICK is 10000
> >  * microseconds (100KHz).  However, this default setting can be
> overridden
> >  * by defining the interval in microseconds as CONFIG_USEC_PER_TICK in
> the
> > ]]]
> >
> > The mistake: if USEC_PER_TICK is 10000 by default, that should be 100
> > Hz, not 100 KHz.
> >
> > Did I find an error or did I miss something?
> >
> > Nathan
> >
>

Re: Mistake in comment describing USEC_PER_TICK?

Posted by Alan Carvalho de Assis <ac...@gmail.com>.
You are right, it should be 100Hz instead 100KHz.

On 11/22/20, Nathan Hartman <ha...@gmail.com> wrote:
> Is there a mistake in the following comment in include/nuttx/clock.h?
>
> [[[
> /* If CONFIG_SCHED_TICKLESS is not defined, then the interrupt interval of
>  * the system timer is given by USEC_PER_TICK.  This is the expected number
>  * of microseconds between calls from the processor-specific logic to
>  * nxsched_process_timer().  The default value of USEC_PER_TICK is 10000
>  * microseconds (100KHz).  However, this default setting can be overridden
>  * by defining the interval in microseconds as CONFIG_USEC_PER_TICK in the
> ]]]
>
> The mistake: if USEC_PER_TICK is 10000 by default, that should be 100
> Hz, not 100 KHz.
>
> Did I find an error or did I miss something?
>
> Nathan
>