You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/12/02 23:29:32 UTC

[GitHub] spark pull request: [SPARK-4695][SQL] Get result using executeColl...

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3547#discussion_r21197678
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -416,6 +416,8 @@ object HiveContext {
         case (bin: Array[Byte], BinaryType) => new String(bin, "UTF-8")
         case (decimal: Decimal, DecimalType()) =>  // Hive strips trailing zeros so use its toString
           HiveShim.createDecimal(decimal.toBigDecimal.underlying()).toString
    --- End diff --
    
    I believe this case can be deleted now.  Internal decimal types should never be returned to users.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org