You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/12/26 08:28:08 UTC
[GitHub] [servicecomb-service-center] ChinX opened a new pull request #613:
[SCB-1687] Fix the bug that startup fails when the configuration is
incomplete
ChinX opened a new pull request #613: [SCB-1687] Fix the bug that startup fails when the configuration is incomplete
URL: https://github.com/apache/servicecomb-service-center/pull/613
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] MabinGo commented on issue #613:
[SCB-1687] Fix the bug that startup fails when the configuration is
incomplete
Posted by GitBox <gi...@apache.org>.
MabinGo commented on issue #613: [SCB-1687] Fix the bug that startup fails when the configuration is incomplete
URL: https://github.com/apache/servicecomb-service-center/pull/613#issuecomment-579237380
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #613:
[SCB-1687] Fix the bug that startup fails when the configuration is
incomplete
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #613: [SCB-1687] Fix the bug that startup fails when the configuration is incomplete
URL: https://github.com/apache/servicecomb-service-center/pull/613#issuecomment-569013574
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=h1) Report
> Merging [#613](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/9fa82ac8c847ea6f62161865ad1fccf443d73b3f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 57.57% 57.56% -0.01%
==========================================
Files 205 205
Lines 15776 15778 +2
==========================================
Hits 9083 9083
- Misses 6046 6048 +2
Partials 647 647
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `46.57% <0%> (-1.32%)` | :arrow_down: |
| [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `56.75% <0%> (-2.71%)` | :arrow_down: |
| [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `63.1% <0%> (-0.98%)` | :arrow_down: |
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `80.57% <0%> (-0.58%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: |
| [server/notify/stream.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9zdHJlYW0uZ28=) | `73.68% <0%> (+2.63%)` | :arrow_up: |
| [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/613/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `76.47% <0%> (+5.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=footer). Last update [9fa82ac...1709d73](https://codecov.io/gh/apache/servicecomb-service-center/pull/613?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] MabinGo merged pull request #613:
[SCB-1687] Fix the bug that startup fails when the configuration is
incomplete
Posted by GitBox <gi...@apache.org>.
MabinGo merged pull request #613: [SCB-1687] Fix the bug that startup fails when the configuration is incomplete
URL: https://github.com/apache/servicecomb-service-center/pull/613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #613:
[SCB-1687] Fix the bug that startup fails when the configuration is
incomplete
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #613: [SCB-1687] Fix the bug that startup fails when the configuration is incomplete
URL: https://github.com/apache/servicecomb-service-center/pull/613#issuecomment-569013557
[](https://coveralls.io/builds/27795629)
Coverage decreased (-0.03%) to 60.004% when pulling **1709d731cdf5c332586fadc678d283a28c442d84 on ChinX:syncer** into **9fa82ac8c847ea6f62161865ad1fccf443d73b3f on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services