You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2014/10/09 00:25:00 UTC

git commit: Add more to the TODO comment.

Repository: qpid-jms
Updated Branches:
  refs/heads/master 803400254 -> 459893d36


Add more to the TODO comment.

Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/459893d3
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/459893d3
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/459893d3

Branch: refs/heads/master
Commit: 459893d36926c73dae7627046c4f70740ab83cc5
Parents: 8034002
Author: Timothy Bish <ta...@gmail.com>
Authored: Wed Oct 8 18:24:55 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Wed Oct 8 18:24:55 2014 -0400

----------------------------------------------------------------------
 .../src/main/java/org/apache/qpid/jms/message/JmsMessage.java    | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/459893d3/qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessage.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessage.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessage.java
index 1a2450e..33ed19c 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessage.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessage.java
@@ -244,6 +244,10 @@ public class JmsMessage implements javax.jms.Message {
 
         //TODO: Handle any other relevant JMSX properties.
         //TODO: Possibly push this to the facade or interceptors?
+        //      It makes sense to chain the call to clear through the JmsMessagePropertyIntercepor
+        //      which would in turn call the clear on the facade which could then allow its own
+        //      intercepter to clear any managed JMS_AMQP properties before the facade does it's
+        //      final clear on the message level properties.
         //Clear property-defined values that are treated as facade-managed, such as GroupSequence.
         facade.clearGroupSequence();
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org