You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/25 13:56:22 UTC

[GitHub] [incubator-kvrocks] jackwener opened a new pull request, #671: enhance: use unique_ptr in Config

jackwener opened a new pull request, #671:
URL: https://github.com/apache/incubator-kvrocks/pull/671

   Part of #663 
   
   In config.cc, use unique_ptr to eliminate some trivial manual deallocation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jackwener commented on pull request #671: enhance: use unique_ptr in Config

Posted by GitBox <gi...@apache.org>.

jackwener commented on PR #671:
URL: https://github.com/apache/incubator-kvrocks/pull/671#issuecomment-1166311728

   I have use `emplace_back` place the vector [List-initialization](https://en.cppreference.com/w/cpp/language/list_initialization).
   
   Because it will use `copy constructor`, it will call `FieldWrapper(const FieldWrapper &wrapper)`.
   
   So, I use `emplace_back`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jackwener closed pull request #671: enhance: use unique_ptr in Config

Posted by GitBox <gi...@apache.org>.

jackwener closed pull request #671: enhance: use unique_ptr in Config
URL: https://github.com/apache/incubator-kvrocks/pull/671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org