You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "syun64 (via GitHub)" <gi...@apache.org> on 2023/10/29 18:12:04 UTC
[PR] Bug fix fetch_callback of Partial Subset DAG [airflow]
syun64 opened a new pull request, #35256:
URL: https://github.com/apache/airflow/pull/35256
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
I believe that there may be a bug where if a partial_subset dag is generated on a DAG with `on_success_callback` or `on_failure_callback` functions defined on it, then it might try to look for a TI that is not actually a part of the partial subset DAG. This is because we fetch the last TI available from the DagRun within `DAG.fetch_callback`, and a DagRun isn't aware of the concept of a partial subset. Hence `ti.task = dag.get_task(ti.task_id)` results in a `TaskNotFound` exception.
In this PR, we are:
1. Adding DAG callback functions to the test DAG defined in tests/jobs/test_backfill_job.py::TestBackfillJob::test_sub_set_subdag to cover this test case (which fails without below patch)
2. If dag.partial, we filter out tis where ti.state == State.NONE within `DAG.fetch_callback`
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]
Posted by "syun64 (via GitHub)" <gi...@apache.org>.
syun64 commented on code in PR #35256:
URL: https://github.com/apache/airflow/pull/35256#discussion_r1377747632
##########
airflow/models/dag.py:
##########
@@ -1428,6 +1428,13 @@ def fetch_callback(
dagrun = DAG.fetch_dagrun(dag_id=dag.dag_id, run_id=dag_run_id, session=session)
callbacks = callbacks if isinstance(callbacks, list) else [callbacks]
tis = dagrun.get_task_instances(session=session)
+ # tis from a dagrun may not be a part of dag.partial_subset,
+ # since dag.partial_subset is a subset of the dag.
+ # This ensures that we will only use the accessible TI
+ # context for the callback.
+ if dag.partial:
+ tis = [ti for ti in tis if not ti.state == State.NONE]
+ # tis = [ti for ti in tis if ti.task_id in dag.task_dict.keys()]
Review Comment:
Thanks for the catch @Lee-W
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #35256:
URL: https://github.com/apache/airflow/pull/35256#discussion_r1375999496
##########
airflow/models/dag.py:
##########
@@ -1428,6 +1428,13 @@ def fetch_callback(
dagrun = DAG.fetch_dagrun(dag_id=dag.dag_id, run_id=dag_run_id, session=session)
callbacks = callbacks if isinstance(callbacks, list) else [callbacks]
tis = dagrun.get_task_instances(session=session)
+ # tis from a dagrun may not be a part of dag.partial_subset,
+ # since dag.partial_subset is a subset of the dag.
+ # This ensures that we will only use the accessible TI
+ # context for the callback.
+ if dag.partial:
+ tis = [ti for ti in tis if not ti.state == State.NONE]
+ # tis = [ti for ti in tis if ti.task_id in dag.task_dict.keys()]
Review Comment:
Should we remove this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #35256:
URL: https://github.com/apache/airflow/pull/35256#issuecomment-1795301895
Done! Thanks for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]
Posted by "syun64 (via GitHub)" <gi...@apache.org>.
syun64 commented on PR #35256:
URL: https://github.com/apache/airflow/pull/35256#issuecomment-1795207176
Thank you for the review @vincbeck . Would you be able to merge this in? Unfortunately I do not have write access to the repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bug fix fetch_callback of Partial Subset DAG [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #35256:
URL: https://github.com/apache/airflow/pull/35256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org